You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(Didn't follow for the format as this is a general capability request, for any version)
Following from #812 and reading through some of the code in lib/configure.js and https://github.com/nodejs/node-gyp/blob/main/lib/find-node-directory.js, could the general strategy of inferring the nodedir through a traversal from process.execPath work to automatically find headers files even when using non-standard installation locations of node?
In other words, infer the npm_config_nodedir from the execPath, instead of requiring users set it explicitly:
My main hesitation is I don't know if this could accidentally end up with false-positive identification in a lot of the cases for some reason, or otherwise break some ecosystem usage. It could also be behind a flag or variable like --infer-nodedir / npm_config_infer_nodedir if that's a concern, though of course preferably it could be a default.
The text was updated successfully, but these errors were encountered:
(Didn't follow for the format as this is a general capability request, for any version)
Following from #812 and reading through some of the code in
lib/configure.js
and https://github.com/nodejs/node-gyp/blob/main/lib/find-node-directory.js, could the general strategy of inferring thenodedir
through a traversal fromprocess.execPath
work to automatically find headers files even when using non-standard installation locations of node?In other words, infer the
npm_config_nodedir
from theexecPath
, instead of requiring users set it explicitly:My main hesitation is I don't know if this could accidentally end up with false-positive identification in a lot of the cases for some reason, or otherwise break some ecosystem usage. It could also be behind a flag or variable like
--infer-nodedir
/npm_config_infer_nodedir
if that's a concern, though of course preferably it could be a default.The text was updated successfully, but these errors were encountered: