Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is package-lock.json ignored? #3060

Open
cinderblock opened this issue Aug 19, 2024 · 0 comments
Open

Why is package-lock.json ignored? #3060

cinderblock opened this issue Aug 19, 2024 · 0 comments

Comments

@cinderblock
Copy link

This was first brought up in a review. A couple people mentioned this. No action was taken.

https://github.com/nodejs/node-gyp/pull/1573/files/020e2bdb6836b57462cccac6083a67f074019658#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947

Why is package-lock.json ignored? https://github.com/nodejs/node-gyp/blob/main/.gitignore#L7

The general consensus seems to bee that it should be committed. If there is a reason it shouldn't, it should probably be listed alongside the ignore (as a comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant