Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target make file contains syntax which is not interpreted correctly on AIX #3108

Open
ritvick opened this issue Dec 6, 2024 · 2 comments
Open

Comments

@ritvick
Copy link

ritvick commented Dec 6, 2024

  • Node Version: node v18.20.5 , npm 10.8.2
  • Platform: AIX PPC 64
  • Compiler: gcc version 10.3.0 (GCC)
  • Module: Proprietary custom module
Target make file contains syntax which is not interpreted correctly on AIX
gyp info it worked if it ends with ok
gyp verb cli [
gyp verb cli '/home/user/user1/node-v18.20.5-aix-ppc64/bin/node',
gyp verb cli '/tmp/custom_package/node_modules/.bin/node-gyp',
gyp verb cli 'rebuild',
gyp verb cli '--verbose',
gyp verb cli '--target=v18.20.5',
gyp verb cli '--release',
gyp verb cli '--msvs_version=2019',
gyp verb cli '--buildfolder=Release',
gyp verb cli '--linux_variant=undefined',
gyp verb cli '--v8_enable_pointer_compression=false',
gyp verb cli '--v8_enable_31bit_smis_on_64bit_arch=false',
gyp verb cli '--build_v8_with_gn=false',
gyp verb cli '--enable_lto=false'
gyp verb cli ]
gyp info using [email protected]
gyp info using [email protected] | aix | ppc64
gyp verb clean removing "build" directory
gyp verb find Python Python is not set from command line or npm configuration
gyp verb find Python Python is not set from environment variable PYTHON
gyp verb find Python checking if "python3" can be used
gyp verb find Python - executing "python3" to get executable path
gyp verb find Python - executable path is "/usr/bin/python3"
gyp verb find Python - executing "/usr/bin/python3" to get version
gyp verb find Python - version is "3.9.6"
gyp info find Python using Python version 3.9.6 found at "/usr/bin/python3"
gyp verb get node dir no --target version specified, falling back to host node version: 18.20.5

gyp verb install input version string "18.20.5"
gyp verb install installing version: 18.20.5
gyp verb install --ensure was passed, so won't reinstall if already installed
gyp verb install version is already installed, need to check "installVersion"
gyp verb got "installVersion" 11
gyp verb needs "installVersion" 11
gyp verb install version is good
gyp verb get node dir target node version installed: 18.20.5
.
.
.
.
g++ -shared -Wl ........
/bin/sh: syntax error at line 1 : `(' unexpected
gmake: Leaving directory '/tmp/custom_package/nodejs/src/custom_package/node_modules/custom_package-napi/build'
gmake: *** [custom_package.target.mk:279: Release/obj.target/custom_package.node] Error 2
gyp ERR! build error
gyp ERR! stack Error: `gmake` failed with exit code: 2

The line 279 is " $(call do_cmd,solink_module)" in the generated make file

A few lines above it are:

$(obj).target/custom_module.node: GYP_LDFLAGS := $(LDFLAGS_$(BUILDTYPE))
$(obj).target/custom_module.node: LIBS := $(LIBS)
$(obj).target/custom_module.node: TOOLSET := $(TOOLSET)
$(obj).target/custom_module.node: $(OBJS) FORCE_DO_CMD
        $(call do_cmd,solink_module)

NOTE: This works on all the other platforms linux / windows on pc, amd, arm, mac, graviton. It complains specifically for AIX.

@cclauss
Copy link
Contributor

cclauss commented Dec 6, 2024

What is gyp verb needs "installVersion" 11? Is that https://github.com/nodejs/node-gyp/releases v11? If not, what is v11?

@ritvick
Copy link
Author

ritvick commented Dec 10, 2024

Hi,
This "installVersion" is not https://github.com/nodejs/node-gyp/releases. Its something internal coming from node headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants