From 56dea478d293a0a3f562dbefacddea9a4583f73d Mon Sep 17 00:00:00 2001 From: Szymon Marczak <36894700+szmarczak@users.noreply.github.com> Date: Wed, 16 Oct 2024 02:14:18 +0200 Subject: [PATCH] note --- lib/internal/http2/core.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js index 2d4a347892a094..25ca599abe6945 100644 --- a/lib/internal/http2/core.js +++ b/lib/internal/http2/core.js @@ -2330,8 +2330,10 @@ class Http2Stream extends Duplex { if (!this.closed) { let goawayCode = sessionState.goawayCode; if (goawayCode === NGHTTP2_NO_ERROR) { - // Received NO_ERROR (GOAWAY) from remote peer yet still got reset - goawayCode = NGHTTP2_INTERNAL_ERROR; + // Received NO_ERROR (GOAWAY) from remote peer yet still got reset. + // This needs to be null because the other side is within its rights + // to TCP RST after we send non-zero GOAWAY. + goawayCode = null; } let destroyCode = sessionState.destroyCode;