From 6e42433054c46aee76b4dab7ade49a0450892363 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerhard=20St=C3=B6bich?= Date: Sat, 7 Dec 2024 23:31:45 +0100 Subject: [PATCH] Revert "build: avoid compiling with VS v17.12" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 542f252d3672f586db07112fe2d844a5d1417e3a. PR-URL: https://github.com/nodejs/node/pull/56151 Refs: https://github.com/nodejs/build/issues/3963 Refs: https://github.com/nodejs/node/pull/55930 Reviewed-By: Richard Lau Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Stefan Stojanovic --- vcbuild.bat | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/vcbuild.bat b/vcbuild.bat index 59197c1ccc36e3..f93998d2b14901 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -292,19 +292,10 @@ goto exit @rem Visual Studio v17.10 has a bug that causes the build to fail. @rem Check if the version is v17.10 and exit if it is. echo %VSCMD_VER% | findstr /b /c:"17.10" >nul -if %errorlevel% neq 1 ( +if %errorlevel% neq 1 ( echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version. goto exit ) -@rem Same applies to v17.12 for MSVC. -echo %VSCMD_VER% | findstr /b /c:"17.12" >nul -if %errorlevel% neq 1 ( - @rem Clang 18.1.8 Provided with VS 17.12 works fine. - if not defined clang_cl ( - echo Node.js doesn't compile with Visual Studio 17.12 Please use a different version. - goto exit - ) -) @rem check if the clang-cl build is requested if not defined clang_cl goto clang-skip