diff --git a/configure.py b/configure.py index a6f66c41f75bff..0d089c35d1720e 100755 --- a/configure.py +++ b/configure.py @@ -2249,8 +2249,9 @@ def make_bin_override(): if options.compile_commands_json: gyp_args += ['-f', 'compile_commands_json'] - os.path.islink('./compile_commands.json') and os.unlink('./compile_commands.json') - os.symlink('./out/' + config['BUILDTYPE'] + '/compile_commands.json', './compile_commands.json') + if sys.platform != 'win32': + os.path.lexists('./compile_commands.json') and os.unlink('./compile_commands.json') + os.symlink('./out/' + config['BUILDTYPE'] + '/compile_commands.json', './compile_commands.json') # pass the leftover non-whitespace positional arguments to GYP gyp_args += [arg for arg in args if not str.isspace(arg)] @@ -2260,4 +2261,7 @@ def make_bin_override(): print_verbose("running: \n " + " ".join(['python', 'tools/gyp_node.py'] + gyp_args)) run_gyp(gyp_args) +if options.compile_commands_json and sys.platform == 'win32': + os.path.isfile('./compile_commands.json') and os.unlink('./compile_commands.json') + shutil.copy2('./out/' + config['BUILDTYPE'] + '/compile_commands.json', './compile_commands.json') info('configure completed successfully') diff --git a/vcbuild.bat b/vcbuild.bat index 01c1102343d64c..d39632c784279d 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -66,6 +66,7 @@ set openssl_no_asm= set no_shared_roheap= set doc= set extra_msbuild_args= +set compile_commands= set exit_code=0 :next-arg @@ -140,6 +141,7 @@ if /i "%1"=="openssl-no-asm" set openssl_no_asm=1&goto arg-ok if /i "%1"=="no-shared-roheap" set no_shared_roheap=1&goto arg-ok if /i "%1"=="doc" set doc=1&goto arg-ok if /i "%1"=="binlog" set extra_msbuild_args=/binaryLogger:out\%config%\node.binlog&goto arg-ok +if /i "%1"=="compile-commands" set compile_commands=1&goto arg-ok echo Error: invalid command line option `%1`. exit /b 1 @@ -196,6 +198,7 @@ if defined debug_nghttp2 set configure_flags=%configure_flags% --debug-nghttp if defined openssl_no_asm set configure_flags=%configure_flags% --openssl-no-asm if defined no_shared_roheap set configure_flags=%configure_flags% --disable-shared-readonly-heap if defined DEBUG_HELPER set configure_flags=%configure_flags% --verbose +if defined compile_commands set configure_flags=%configure_flags% -C if "%target_arch%"=="x86" if "%PROCESSOR_ARCHITECTURE%"=="AMD64" set configure_flags=%configure_flags% --no-cross-compiling if not exist "%~dp0deps\icu" goto no-depsicu