Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gyp changes for OpenSSL 3 should be upstreamed to nodejs/gyp-next #40735

Closed
targos opened this issue Nov 6, 2021 · 1 comment · Fixed by nodejs/gyp-next#147
Closed

gyp changes for OpenSSL 3 should be upstreamed to nodejs/gyp-next #40735

targos opened this issue Nov 6, 2021 · 1 comment · Fixed by nodejs/gyp-next#147
Labels
gyp Issues and PRs related to the GYP tool and .gyp build files openssl Issues and PRs related to the OpenSSL dependency.

Comments

@targos
Copy link
Member

targos commented Nov 6, 2021

There are changes from two commits that aren't in gyp-next and are causing issues with nodejs/gyp-next#131:

/cc @danbev
@targos targos added gyp Issues and PRs related to the GYP tool and .gyp build files openssl Issues and PRs related to the OpenSSL dependency. labels Nov 6, 2021
@targos targos mentioned this issue Nov 6, 2021
Open
@richardlau richardlau mentioned this issue Nov 23, 2021
Merged
@Trott Trott mentioned this issue Dec 20, 2021
Merged
@targos targos mentioned this issue Apr 6, 2022
Closed
@ryzokuken ryzokuken mentioned this issue Apr 14, 2022
Closed
@gengjiawen gengjiawen mentioned this issue May 6, 2022
Closed
@targos
Copy link
Member Author

targos commented May 6, 2022

Also #42986 if it lands.

@gengjiawen gengjiawen mentioned this issue May 6, 2022
Merged
danbev added a commit to danbev/gyp-next that referenced this issue May 9, 2022
@danbev
fix: update with changes for OpenSSL 3.x
d4dbe56 
This commit updates __init__.py with changes that were made directly
in Node.js (sorry about this but at the time I was not aware that there
this upstream repo existed).

It includes changes from two commits in Node.js:
 Commit f4bd91b0e2d7f07365ccf6bba943ba97d6f95cc9 ("deps,build,
tools: fix openssl-is-fips for ninja builds) and
Commit 66da32c045035cf2710a48773dc6f55f00e20c40 ("deps,test,src,doc,
tools: update to OpenSSL 3.0")

Refs: nodejs/node#40735
@danbev danbev mentioned this issue May 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gyp Issues and PRs related to the GYP tool and .gyp build files openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: execvp: printf: Argument list too long gengjiawen/gyp-next
1 participant
@targos