Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddressSanitizer: container-overflow during package.json resolution with simdjson #55584

Closed
codebytere opened this issue Oct 29, 2024 · 11 comments · Fixed by #55591
Closed

AddressSanitizer: container-overflow during package.json resolution with simdjson #55584

codebytere opened this issue Oct 29, 2024 · 11 comments · Fixed by #55591

Comments

@codebytere
Copy link
Member

codebytere commented Oct 29, 2024 •
edited
Loading

Version

main

Platform

Linux 5469246cac8b 6.5.0-1025-azure #26~22.04.1-Ubuntu SMP Thu Jul 11 22:33:04 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

  1. Clone https://gist.github.com/codebytere/3dedc548edcc0cc218d1ec85d8b61b02
  2. Enter the directory and install modules with npm i
  3. Use an asan-enabled Node.js build to run the file
  4. Observe ASAN crash

How often does it reproduce? Is there a required condition?

Every time.

What is the expected behavior? Why is that the expected behavior?

No crash.

What do you see instead?

=================================================================
==625312==ERROR: AddressSanitizer: container-overflow on address 0x7bf653f0e7b7 at pc 0x5891de703a35 bp 0x7fffc7b5e470 sp 0x7fffc7b5e468
READ of size 32 at 0x7bf653f0e7b7 thread T0
    #0 0x5891de703a34 in load third_party/electron_node/deps/simdjson/simdjson.cpp:14372:14
    #1 0x5891de703a34 in simd8 third_party/electron_node/deps/simdjson/simdjson.cpp:14525:61
    #2 0x5891de703a34 in copy_and_find third_party/electron_node/deps/simdjson/simdjson.cpp:14699:18
    #3 0x5891de703a34 in parse_string third_party/electron_node/deps/simdjson/simdjson.cpp:19596:21
    #4 0x5891de703a34 in simdjson::haswell::dom_parser_implementation::parse_string(unsigned char const*, unsigned char*, bool) const third_party/electron_node/deps/simdjson/simdjson.cpp:20193:10
    #5 0x5891de1bb79f in unescape third_party/electron_node/deps/simdjson/simdjson.h:49904:34
    #6 0x5891de1bb79f in unescape third_party/electron_node/deps/simdjson/simdjson.h:48874:18
    #7 0x5891de1bb79f in unescape third_party/electron_node/deps/simdjson/simdjson.h:50092:15
    #8 0x5891de1bb79f in unescape third_party/electron_node/deps/simdjson/simdjson.h:50130:16
    #9 0x5891de1bb79f in get_string third_party/electron_node/deps/simdjson/simdjson.h:51535:32
    #10 0x5891de1bb79f in get_string<std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > > > third_party/electron_node/deps/simdjson/simdjson.h:51540:14
    #11 0x5891de1bb79f in get_string<std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > > > third_party/electron_node/deps/simdjson/simdjson.h:50528:15
    #12 0x5891de1bb79f in node::modules::BindingData::GetPackageJSON(node::Realm*, std::__Cr::basic_string_view<char, std::__Cr::char_traits<char>>, node::modules::BindingData::ErrorContext*) third_party/electron_node/src/node_modules.cc:162:17
    #13 0x5891de1c0b8f in node::modules::BindingData::ReadPackageJSON(v8::FunctionCallbackInfo<v8::Value> const&) third_party/electron_node/src/node_modules.cc:271:23
    #14 0x5891d61e586d in Builtins_CallApiCallbackGeneric setup-isolate-deserialize.cc
    #15 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #16 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #17 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #18 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #19 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #20 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #21 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #22 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #23 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #24 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #25 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #26 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #27 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #28 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #29 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #30 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #31 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #32 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #33 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #34 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #35 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #36 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #37 0x5891d61e0fdb in Builtins_JSEntryTrampoline setup-isolate-deserialize.cc
    #38 0x5891d61e0d1e in Builtins_JSEntry setup-isolate-deserialize.cc
    #39 0x5891d11e9fc3 in Call v8/src/execution/simulator.h:191:12
    #40 0x5891d11e9fc3 in v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) v8/src/execution/execution.cc:420:22
    #41 0x5891d11e8c4a in v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) v8/src/execution/execution.cc:506:10
    #42 0x5891d0976e50 in v8::Function::Call(v8::Isolate*, v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*) v8/src/api/api.cc:5601:7
    #43 0x5891de04d430 in CompileAndCall third_party/electron_node/src/node_builtins.cc:497:14
    #44 0x5891de04d430 in node::builtins::BuiltinLoader::CompileAndCall(v8::Local<v8::Context>, char const*, node::Realm*) third_party/electron_node/src/node_builtins.cc:481:10
    #45 0x5891de25c7f8 in node::Realm::ExecuteBootstrapper(char const*) third_party/electron_node/src/node_realm.cc:161:32
    #46 0x5891ddfd9ba0 in node::StartExecution(node::Environment*, char const*) third_party/electron_node/src/node.cc:297:35
    #47 0x5891ddfd96bc in node::StartExecution(node::Environment*, std::__Cr::function<v8::MaybeLocal<v8::Value> (node::StartExecutionCallbackInfo const&)>) third_party/electron_node/src/node.cc
    #48 0x5891dde03a72 in node::LoadEnvironment(node::Environment*, std::__Cr::function<v8::MaybeLocal<v8::Value> (node::StartExecutionCallbackInfo const&)>, std::__Cr::function<void (node::Environment*, v8::Local<v8::Value>, v8::Local<v8::Value>)>) third_party/electron_node/src/api/environment.cc:534:10
    #49 0x5891c9464568 in electron::NodeMain(int, char**) electron/shell/app/node_main.cc:287:5
    #50 0x5891c945759a in main electron/shell/app/electron_main_linux.cc:34:12
    #51 0x7e96559e2082 in __libc_start_main /build/glibc-LcI20x/glibc-2.31/csu/../csu/libc-start.c:308:16

0x7bf653f0e7b7 is located 567 bytes inside of 616-byte region [0x7bf653f0e580,0x7bf653f0e7e8)
allocated by thread T0 here:
    #0 0x5891c93fdbdd in operator new(unsigned long) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cpp:86:3
    #1 0x5891c9d2876f in __libcpp_operator_new<unsigned long> third_party/libc++/src/include/new:277:10
    #2 0x5891c9d2876f in __libcpp_allocate third_party/libc++/src/include/new:301:10
    #3 0x5891c9d2876f in allocate third_party/libc++/src/include/__memory/allocator.h:103:32
    #4 0x5891c9d2876f in __allocate_at_least<std::__Cr::allocator<char> > third_party/libc++/src/include/__memory/allocate_at_least.h:41:19
    #5 0x5891c9d2876f in std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>::__shrink_or_extend(unsigned long) third_party/libc++/src/include/string
    #6 0x5891de1ba698 in iterate third_party/electron_node/deps/simdjson/simdjson.h:49828:10
    #7 0x5891de1ba698 in node::modules::BindingData::GetPackageJSON(node::Realm*, std::__Cr::basic_string_view<char, std::__Cr::char_traits<char>>, node::modules::BindingData::ErrorContext*) third_party/electron_node/src/node_modules.cc:107:33
    #8 0x5891de1c0b8f in node::modules::BindingData::ReadPackageJSON(v8::FunctionCallbackInfo<v8::Value> const&) third_party/electron_node/src/node_modules.cc:271:23
    #9 0x5891d61e586d in Builtins_CallApiCallbackGeneric setup-isolate-deserialize.cc
    #10 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #11 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #12 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #13 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #14 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #15 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #16 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #17 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #18 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #19 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #20 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #21 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #22 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #23 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #24 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #25 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #26 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #27 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #28 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #29 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #30 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #31 0x5891d61e3a1d in Builtins_InterpreterEntryTrampoline setup-isolate-deserialize.cc
    #32 0x5891d61e0fdb in Builtins_JSEntryTrampoline setup-isolate-deserialize.cc
    #33 0x5891d61e0d1e in Builtins_JSEntry setup-isolate-deserialize.cc
    #34 0x5891d11e9fc3 in Call v8/src/execution/simulator.h:191:12
    #35 0x5891d11e9fc3 in v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) v8/src/execution/execution.cc:420:22

HINT: if you don't care about these errors you may set ASAN_OPTIONS=detect_container_overflow=0.
If you suspect a false positive see also: https://github.com/google/sanitizers/wiki/AddressSanitizerContainerOverflow.
SUMMARY: AddressSanitizer: container-overflow third_party/electron_node/deps/simdjson/simdjson.cpp:14372:14 in load
Shadow bytes around the buggy address:
  0x7bf653f0e500: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x7bf653f0e580: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x7bf653f0e600: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x7bf653f0e680: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x7bf653f0e700: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x7bf653f0e780: 00 00 00 00 02 fc[fc]fc fc fc fc fc fc fa fa fa
  0x7bf653f0e800: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x7bf653f0e880: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x7bf653f0e900: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x7bf653f0e980: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x7bf653f0ea00: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==625312==ABORTING
ERROR Error: Command failed: /workspaces/gclient/src/out/Testing/electron index.js

Additional information

It appears potentially specific to the location of the main key in package.json - so far I'm consistently able to reproduce this with cookie-signature which has its main entry at the bottom. I'm not yet sure what other main entries could cause this, and have confirmed that moving main nearer to the top fixes the crash.

Refs #50322 cc @anonrig @lemire
@codebytere codebytere mentioned this issue Oct 29, 2024
Merged
@lemire
Copy link
Member

lemire commented Oct 29, 2024

@codebytere

Thanks for the report. I will be investigating this morning.

cc @anonrig

@codebytere
Copy link
Member Author

codebytere commented Oct 29, 2024 •
edited
Loading

@lemire you might already know this, but if not, ASAN appears broken in main right now as a result of a V8 bump from 3ish months ago (#54447). ASAN still works in Electron's GN build of Node.js though, and we don't patch anything to do with this area of the codebase, so I used our build's executable to repro. Let me know if you need any other info, and appreciate your investigating!

@lemire
Copy link
Member

lemire commented Oct 29, 2024

@codebytere I am somewhat puzzled by the trace. You see this line...

    #4 0x5891de703a34 in simdjson::haswell::dom_parser_implementation::parse_string(unsigned char const*, unsigned char*, bool) const third_party/electron_node/deps/simdjson/simdjson.cpp:20193:10

???

It indicates that the system detected an Intel Haswell-like CPU (so with AVX2).

But then you indicate the platform as being...

Darwin MacBookPro.fritz.box 24.1.0 Darwin Kernel Version 24.1.0: Thu Oct 10 21:03:15 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6000 arm64

... which indicates an ARM-based system.

Is this running under rosetta?

@lemire
Copy link
Member

lemire commented Oct 29, 2024 •
edited
Loading

@codebytere Can you specify the precise node version? (E.g., commit hash.)

The stack trace indicates the following as the starting point...

 third_party/electron_node/src/node_modules.cc:162:17

But that does not match the content of that line:

node/src/node_modules.cc

Line 162 in 4354a1d

return throw_invalid_package_config();

@codebytere
Copy link
Member Author

codebytere commented Oct 29, 2024 •
edited
Loading

@lemire you're right, my apologies - the stacktrace is from a Linux x64 VM. I've corrected it now, and the specific line causing the crash is:

node/src/node_modules.cc

Line 159 in 317d245

USE(value.get_string(package_config.main));

The reason it said L162 is because I added some logging locally:


    fprintf(stderr, "key: %s\n", key.raw());
    fprintf(stderr, "path: %s\n", path.data());

to help verify the contents of the package.json causing the crash, which is how i determined it was the cookie-signature package. The commit i've checked out is 4631be0.

@lemire
Copy link
Member

lemire commented Oct 29, 2024

@codebytere That's useful.

So tracing it back, we have this JSON file...

{
  "name": "cookie-signature",
  "version": "1.2.1",
  "description": "Sign and unsign cookies",
  "keywords": ["cookie", "sign", "unsign"],
  "author": "TJ Holowaychuk <[email protected]>",
  "license": "MIT",
  "repository": {
    "type": "git",
    "url": "https://github.com/visionmedia/node-cookie-signature.git"
  },
  "dependencies": {},
  "engines": {
    "node": ">=6.6.0"
  },
  "devDependencies": {
    "mocha": "*",
    "should": "*"
  },
  "scripts": {
    "test": "mocha --require should --reporter spec"
  },
  "main": "index"
}

And there is an issue where we try to read "index" (at the end) and somehow read too many bytes....

@codebytere
Copy link
Member Author

codebytere commented Oct 29, 2024 •
edited
Loading

I also played around a bit with key order and it looks like as long as main isn't the absolute last item it won't crash - the order of other keys before it doesn't seem to matter

@lemire
Copy link
Member

lemire commented Oct 29, 2024

It is not specific to AVX2 or any such thing.

@lemire
Copy link
Member

lemire commented Oct 29, 2024

Oh.

I understand. I did not know about container overflows, but this is done deliberately:

https://github.com/google/sanitizers/wiki/AddressSanitizerContainerOverflow

@lemire
Copy link
Member

lemire commented Oct 29, 2024

To be clear, this is a false positive.

@lemire lemire changed the title ASAN crash during package.json resolution with simdjson AddressSanitizer: container-overflow during package.json resolution with simdjson Oct 29, 2024
@lemire lemire mentioned this issue Oct 29, 2024
Merged
@lemire lemire linked a pull request Oct 29, 2024 that will close this issue
src: provide workaround for container-overflow (issue 55584) #55591
Merged
@lemire
Copy link
Member

lemire commented Oct 29, 2024

Please see #55591

codebytere added a commit to electron/electron that referenced this issue Oct 29, 2024
@codebytere
build: set ASAN detect_container_overflow=0
95b5904 
nodejs/node#55584
codebytere added a commit to electron/electron that referenced this issue Oct 29, 2024
@codebytere
build: set ASAN detect_container_overflow=0
b9e222e 
nodejs/node#55584
codebytere added a commit to electron/electron that referenced this issue Oct 31, 2024
@codebytere
build: set ASAN detect_container_overflow=0
5bc31bd 
nodejs/node#55584
@codebytere codebytere mentioned this issue Oct 31, 2024
Merged
5 tasks
@jkleinsc jkleinsc mentioned this issue Nov 4, 2024
Closed
jkleinsc pushed a commit to electron/electron that referenced this issue Nov 4, 2024
@codebytere
chore: bump Node.js to v22.9.0 (#44281)
c63d0d6 
* chore: bump Node.js to v22.9.0

* build: drop base64 dep in GN build

nodejs/node#52856

* build,tools: make addons tests work with GN

nodejs/node#50737

* fs: add fast api for InternalModuleStat

nodejs/node#51344

* src: move package_json_reader cache to c++

nodejs/node#50322

* crypto: disable PKCS#1 padding for privateDecrypt

nodejs-private/node-private#525

* src: move more crypto code to ncrypto

nodejs/node#54320

* crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey

nodejs/node#50234

* src: shift more crypto impl details to ncrypto

nodejs/node#54028

* src: switch crypto APIs to use Maybe<void>

nodejs/node#54775

* crypto: remove DEFAULT_ENCODING

nodejs/node#47182

* deps: update libuv to 1.47.0

nodejs/node#50650

* build: fix conflict gyp configs

nodejs/node#53605

* lib,src: drop --experimental-network-imports

nodejs/node#53822

* esm: align sync and async load implementations

nodejs/node#49152

* esm: remove unnecessary toNamespacedPath calls

nodejs/node#53656

* module: detect ESM syntax by trying to recompile as SourceTextModule

nodejs/node#52413

* test: adapt debugger tests to V8 11.4

nodejs/node#49639

* lib: update usage of always on Atomics API

nodejs/node#49639

* test: adapt test-fs-write to V8 internal changes

nodejs/node#49639

* test: adapt to new V8 trusted memory spaces

nodejs/node#50115

* deps: update libuv to 1.47.0

nodejs/node#50650

* src: use non-deprecated v8::Uint8Array::kMaxLength

nodejs/node#50115

* src: update default V8 platform to override functions with location

nodejs/node#51362

* src: add missing TryCatch

nodejs/node#51362

* lib,test: handle new Iterator global

nodejs/node#51362

* src: use non-deprecated version of CreateSyntheticModule

nodejs/node#50115

* src: remove calls to recently deprecated V8 APIs

nodejs/node#52996

* src: use new V8 API to define stream accessor

nodejs/node#53084

* src: do not use deprecated V8 API

nodejs/node#53084

* src: do not use soon-to-be-deprecated V8 API

nodejs/node#53174

* src: migrate to new V8 interceptors API

nodejs/node#52745

* src: use supported API to get stalled TLA messages

nodejs/node#51362

* module: print location of unsettled top-level await in entry points

nodejs/node#51999

* test: make snapshot comparison more flexible

nodejs/node#54375

* test: do not set concurrency on parallelized runs

nodejs/node#52177

* src: move FromNamespacedPath to path.cc

nodejs/node#53540

* test: adapt to new V8 trusted memory spaces

nodejs/node#50115

* build: add option to enable clang-cl on Windows

nodejs/node#52870

* chore: fixup patch indices

* chore: add/remove changed files

* esm: drop support for import assertions

nodejs/node#54890

* build: compile with C++20 support

nodejs/node#52838

* deps: update nghttp2 to 1.62.1

nodejs/node#52966

* src: parse inspector profiles with simdjson

nodejs/node#51783

* build: add GN build files

nodejs/node#47637

* deps,lib,src: add experimental web storage

nodejs/node#52435

* build: add missing BoringSSL dep

* src: rewrite task runner in c++

nodejs/node#52609

* fixup! build: add GN build files

* src: stop using deprecated fields of v8::FastApiCallbackOptions

nodejs/node#54077

* fix: shadow variable

* build: add back incorrectly removed SetAccessor patch

* fixup! fixup! build: add GN build files

* crypto: fix integer comparison in crypto for BoringSSL

* src,lib: reducing C++ calls of esm legacy main resolve

nodejs/node#48325

* src: move more crypto_dh.cc code to ncrypto

nodejs/node#54459

* chore: fixup GN files for previous commit

* src: move more crypto code to ncrypto

nodejs/node#54320

* Fixup Perfetto ifdef guards

* fix: missing electron_natives dep

* fix: node_use_node_platform = false

* fix: include src/node_snapshot_stub.cc in libnode

* 5507047: [import-attributes] Remove support for import assertions

https://chromium-review.googlesource.com/c/v8/v8/+/5507047

* fix: restore v8-sandbox.h in filenames.json

* fix: re-add original-fs generation logic

* fix: ngtcp2 openssl dep

* test: try removing NAPI_VERSION undef

* chore(deps): bump @types/node

* src: move more crypto_dh.cc code to ncrypto

nodejs/node#54459

* esm: remove unnecessary toNamespacedPath calls

nodejs/node#53656

* buffer: fix out of range for toString

nodejs/node#54553

* lib: rewrite AsyncLocalStorage without async_hooks

nodejs/node#48528

* module: print amount of load time of a cjs module

nodejs/node#52213

* test: skip reproducible snapshot test on 32-bit

nodejs/node#53592

* fixup! src: move more crypto_dh.cc code to ncrypto

* test: adjust emittedUntil return type

* chore: remove redundant wpt streams patch

* fixup! chore(deps): bump @types/node

* fix: gn executable name on Windows

* fix: build on Windows

* fix: rename conflicting win32 symbols in //third_party/sqlite

On Windows otherwise we get:

lld-link: error: duplicate symbol: sqlite3_win32_write_debug
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:47987
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_sleep
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48042
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_is_nt
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48113
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_unicode
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48470
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_unicode_to_utf8
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48486
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48502
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8_v2
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48518
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48534
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs_v2
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48550
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

* docs: remove unnecessary ts-expect-error after types bump

* src: move package resolver to c++

nodejs/node#50322

* build: set ASAN detect_container_overflow=0

nodejs/node#55584

* chore: fixup rebase

* test: disable failing ASAN test

* win: almost fix race detecting ESRCH in uv_kill

libuv/libuv#4341
aduh95 pushed a commit that referenced this issue Nov 6, 2024
@lemire
src: provide workaround for container-overflow
ccac4ee 
PR-URL: #55591
Refs: #55584
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this issue Nov 6, 2024
@lemire @aduh95
src: provide workaround for container-overflow
46a317f 
PR-URL: #55591
Refs: #55584
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this issue Nov 6, 2024
@lemire @aduh95
src: provide workaround for container-overflow
7853462 
PR-URL: #55591
Refs: #55584
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
@lemire @tpoisseau
src: provide workaround for container-overflow
337e256 
PR-URL: nodejs#55591
Refs: nodejs#55584
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this issue Nov 27, 2024
@lemire @ruyadorno
src: provide workaround for container-overflow
d240f01 
PR-URL: #55591
Refs: #55584
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this issue Nov 27, 2024
@lemire @ruyadorno
src: provide workaround for container-overflow
0987f5a 
PR-URL: #55591
Refs: #55584
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this issue Nov 27, 2024
@lemire @ruyadorno
src: provide workaround for container-overflow
383d284 
PR-URL: #55591
Refs: #55584
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: provide workaround for container-overflow (issue 55584) lemire/node
2 participants
@lemire @codebytere