From 28514f3b24570ada3cb1c3f6e213ffddb877e651 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Sat, 7 Sep 2024 13:50:25 -0700 Subject: [PATCH 1/3] test: reduce stack size for test-error-serdes Hopefully reduces the run time and the likelihood of the test failing with a flaky timeout error. --- test/parallel/test-error-serdes.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-error-serdes.js b/test/parallel/test-error-serdes.js index da09e6ed0a4d9f..bced9cf40b7326 100644 --- a/test/parallel/test-error-serdes.js +++ b/test/parallel/test-error-serdes.js @@ -1,4 +1,4 @@ -// Flags: --expose-internals +// Flags: --expose-internals --stack-size=64 'use strict'; require('../common'); const assert = require('assert'); From 0ebb02da0538bc230e42f0c34611469ea3f4c312 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Sat, 7 Sep 2024 14:00:14 -0700 Subject: [PATCH 2/3] test: remove test-error-serdes from flaky list --- test/parallel/parallel.status | 3 --- 1 file changed, 3 deletions(-) diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index f7e7fa0d8c82cf..7cb9fff60c0390 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -16,9 +16,6 @@ test-worker-arraybuffer-zerofill: PASS, FLAKY # https://github.com/nodejs/node/issues/51862 test-fs-read-stream-concurrent-reads: PASS, FLAKY -# https://github.com/nodejs/node/issues/52630 -test-error-serdes: PASS, FLAKY - # Until V8 provides a better way to check for flag mismatch without # making the code cache/snapshot unreproducible, disable the test # for a preemptive check now. It should idealy fail more gracefully From 4001157838d101325fbc180231e837981272fa81 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Sun, 8 Sep 2024 11:09:02 -0700 Subject: [PATCH 3/3] test: move test-error-serdes to sequential --- test/{parallel => sequential}/test-error-serdes.js | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename test/{parallel => sequential}/test-error-serdes.js (100%) diff --git a/test/parallel/test-error-serdes.js b/test/sequential/test-error-serdes.js similarity index 100% rename from test/parallel/test-error-serdes.js rename to test/sequential/test-error-serdes.js