Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the legacy guide "ABI Stability" to the learn section #6230

Closed
3 tasks
bmuenzenmeyer opened this issue Jan 13, 2024 · 6 comments · Fixed by #6335
Closed
3 tasks

Migrate the legacy guide "ABI Stability" to the learn section #6230

bmuenzenmeyer opened this issue Jan 13, 2024 · 6 comments · Fixed by #6335
Labels
content Issues/pr concerning content good first issue Issues for newcomers help wanted website redesign Issue/PR part of the Node.js Website Redesign

Comments

@bmuenzenmeyer
Copy link
Collaborator

Migrate the content currently at ABI Stability to a new page under the "learn" section found at https://github.com/nodejs/nodejs.org/tree/main/pages/en/learn.

@bmuenzenmeyer bmuenzenmeyer added content Issues/pr concerning content website redesign Issue/PR part of the Node.js Website Redesign help wanted good first issue Issues for newcomers labels Jan 13, 2024
@binary-amigo
Copy link

hello! can you tell me the folder in which the content should be included under the learn section

@mwelwankuta
Copy link
Contributor

hello! can you tell me the folder in which the content should be included under the learn section

@binary-amigo a folder module exists in pages/en/learn/modules the guide can be moved that folder

@officeneerajsaini
Copy link
Contributor

I trust this message finds you well. I've been investigating the ABI Stability issue and it appears to be related to documentation. I propose moving ABI Stability from its current location to a more suitable spot under the "Learn" section.

I'd appreciate your guidance on where to place ABI Stability within the "Learn" section. Considering the existing sections like Getting Started, Asynchronous Work, Manipulating Files, Command Line, and Modules, could you advise on the most fitting position?

Your insights on the issue and the preferred placement would be greatly appreciated.

@mwelwankuta
Copy link
Contributor

mwelwankuta commented Jan 23, 2024

@officeneerajsaini a previous pull request #6232 added a modules folder under the learn section. since the ABI Stability is currently a Module-related guides it's fitting that it also be moved to that learn sub directory

@richardlau
Copy link
Member

If you move this, please add a redirect for https://nodejs.org/en/docs/guides/abi-stability/ to the new location.

GitHub search for the existing URL.

@officeneerajsaini
Copy link
Contributor

@officeneerajsaini a previous pull request #6232 added a modules folder under the learn section. since the ABI Stability is currently a Module-related guides it's fitting that it also be moved to that learn sub directory

thank you for guide me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues/pr concerning content good first issue Issues for newcomers help wanted website redesign Issue/PR part of the Node.js Website Redesign
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants