Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: skip lighthouse CI when no vercel preview detected #7266

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

avivkeller
Copy link
Member

Description

This changes the Lighthouse CI to skip when a Vercel preview is not detected

Related Issues

#7253

Signed-off-by: Aviv Keller <[email protected]>
@avivkeller avivkeller requested a review from Copilot November 20, 2024 21:28
@avivkeller avivkeller requested a review from a team as a code owner November 20, 2024 21:28
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 20, 2024 9:28pm

@avivkeller
Copy link
Member Author

The commit message didn't save 🤔, regardless, the PR title will be used, right? If not, feel free to force push and fix it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

@avivkeller
Copy link
Member Author

image
Without a Vercel preview, the Lighthouse CI is skipped, as shown above.

Copy link
Contributor

github-actions bot commented Nov 23, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 91 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 5.611s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 9202c36 Nov 27, 2024
15 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the chore/redyetidev/lighthouse-skip branch November 27, 2024 12:40
@avivkeller
Copy link
Member Author

👋 follow-up #7361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants