Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test servers may be obscuring bugs #4109

Closed
alxndrsn opened this issue Mar 21, 2025 · 0 comments · Fixed by #4110
Closed

Test servers may be obscuring bugs #4109

alxndrsn opened this issue Mar 21, 2025 · 0 comments · Fixed by #4110
Labels
bug Something isn't working

Comments

@alxndrsn
Copy link
Contributor

Bug Description

While investigating #4103, I noticed that node:http.createServer((req, res) => ... is used in various places in the test suite.

Without the option joinDuplicateHeaders, these servers behave as follows:

If set to true, this option allows joining the field line values of multiple headers in a request with a comma (, ) instead of discarding the duplicates. For more information, refer to message.headers. Default: false.

This is very helpful if trying to implement a well-behaved server, but maybe less helpful if trying to test client behaviour.

Reproducible By

Expected Behavior

joinDuplicateHeaders should be set to true for every invocation of createServer() in tests.

Logs & Screenshots

Environment

Additional context

@alxndrsn alxndrsn added the bug Something isn't working label Mar 21, 2025
alxndrsn pushed a commit to alxndrsn/undici that referenced this issue Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant