Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System package.json #62

Open
usernamefml opened this issue Nov 14, 2017 · 0 comments
Open

System package.json #62

usernamefml opened this issue Nov 14, 2017 · 0 comments

Comments

@usernamefml
Copy link

The readme needs to updating explaining that when you wish to add a node module you need to add it to your system package.json instead of say the npm or github package.json for example.

I came across this problem when I was trying to add seneca-leveldb and tried to install it in nodezoo_npm or nodezoo_github but when I ran the entire setup in docker I could see that it was complaining seneca-leveldb was missing.

The reason for adding it to the system package.json is that when we rebuild the shared docker container all the packages that we need are added from the system package.json which makes sure we can rebuild faster.

So the readme for system needs to be updated explaining how things are built for deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant