Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests Needed #89

Open
powerbrian opened this issue Apr 21, 2016 · 3 comments
Open

Tests Needed #89

powerbrian opened this issue Apr 21, 2016 · 3 comments

Comments

@powerbrian
Copy link

No description provided.

@Georgette
Copy link
Contributor

Georgette commented Apr 25, 2016

So last time I checked, Lab is server side. Certainly don't want to test, even reducers, with a server side framework because it is an entirely different environment.

I'd like to bring in Mocha+Chai+JSDOM(maybe) for front-end testing, which is the typical react-testing suite. I've never tried it, but would like to write a few tests just to get things rolling.

Alternatively, react now has shallow rendering in their testing utils, so we could use Tape -- but shallow render is new, and you might want something with more how-to refs.

@mcdonnelldean

@mcdonnelldean
Copy link
Contributor

Sounds solid!

Kindest Regards,

Dean

On 25 Apr 2016, at 01:25, Gege Pincin [email protected] wrote:

So last time I checked, Lab is server side. Certainly don't want to test, even reducers, with a server side framework because it is an entirely different environment.

I'd like to bring in Mocha+Chai+JSDOM(maybe) for front-end testing, which is the typical react-testing suite. I've never tried it, but would like to write a few tests just to get things rolling. @mcdonnelldean


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@Georgette
Copy link
Contributor

So I just had enough time to get things set up with mocha-chai, leaving behind code coverage setup (maybe instanbul) and travis integration.

Also, and this should be a long term goal, is to integrate with selenium because although most tests cases can be brought against the current virtual dom mock, the one thing we can't ensure if that any of our javascript doesn't break in a particular browser. Selenium also will take screenshots on builds (so we can easily check css support) and some other cool things -- but its really not a necessity. This is simply a step of complete rigor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants