-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for "dropOldest" connection attribute #374
Comments
This should probably be handled using edge metadata similar to the proposal for node metadata in #482 |
Actually I'd say this is a duplicate of #371. Should we close this? |
This issue and all references to it will always exist, even if it is closed. |
Thanks, Chad, but my point is: will it be visible in #371? In this case, On Mon, May 23, 2016 at 12:25 PM, Chad Dombrova [email protected]
|
Doesn't hurt to keep it open. In addition to #371 need to define and document the property and values to use for this specific usage. |
Thanks, Jon - that makes sense to me! On Mon, May 23, 2016 at 12:47 PM, Jon Nordby [email protected]
|
@jonnor, yes, maybe, but first and foremost, it should be up to the runtime to broadcast to the UI the known metadata types that its components/edges/etc support. As @bergie describes in #482 we should "provide a mechanism for runtimes to give [the ui] a metadata JSON schema, so [it] could provide a more specific editor (selects, typed inputs)". As the number of runtimes hooked up to noflo-ui increases, there will be many runtime-specific metadata values. If the UI does not need to understand them to do its job, then it shouldn't get involved. If noflo can eschew runtime-specific feature requests in favor of open systems, we can avoid protracted debates about what should and shouldn't be included, what the names should be, etc. In this case @jpaulm would like to see the edge display customized based on this value, so to achieve that the UI would need to know about this edge property (unless we provide the metadata schema the ability to declare a relationship to certain display properties, but that might be overkill). Anyway, I think we should do #482 and #371, including the metadata schema, and if there's still a need for this feature after those, we can revisit it. |
I don't consider to have 'edge display' customized important. Being able to see and edit the values is the key. I agree that the UI should have no opinion about the contents of metadata. However, for common attributes, it is still desirable to have a convention on what names to use. |
I assume that currently this feature is just a requirement of the JavaFBP However, does anyone visualize supporting multiple run-times with the same On Mon, May 23, 2016 at 3:24 PM, Chad Dombrova [email protected]
|
As per @jonnor 's suggestion, I am raising a specific issue for this.
My art work in DrawFBP uses a squiggly line, but feel free to use any (artistic!) notation you like! :-)
The text was updated successfully, but these errors were encountered: