From f74a8ac96b76d06ed9c884ee6be78910cf529c1a Mon Sep 17 00:00:00 2001
From: Jon <jonathon.lockwood@networkedweb.com>
Date: Thu, 14 Nov 2024 15:54:38 +0930
Subject: [PATCH] fix: correct logic for history route to work

ref: #26 #28 nofusscomputing/centurion_erp#248
---
 src/App.js               |  3 +--
 src/components/Table.jsx |  2 +-
 src/hooks/urlBuilder.js  | 15 +++++++++++----
 src/layout/history.jsx   |  2 +-
 4 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/src/App.js b/src/App.js
index d9f7b02..b5fbdad 100644
--- a/src/App.js
+++ b/src/App.js
@@ -51,13 +51,12 @@ function App() {
                 >
                     <Route path='/login' element={<Login/>}/>
 
-                    <Route path="/core/:model/:pk/:action"
+                    <Route path="/core/:model/:pk/history"
                         element={<History
                             setContentHeading={setContentHeading}
                             SetContentHeaderIcon={SetContentHeaderIcon}
                         />}
                         errorElement={<ErrorPage /> }
-                        loader = {detailsLoader}
                     />
 
                     <Route path="/settings"
diff --git a/src/components/Table.jsx b/src/components/Table.jsx
index 11915dd..fa85096 100644
--- a/src/components/Table.jsx
+++ b/src/components/Table.jsx
@@ -261,7 +261,7 @@ const Table = ({
                                     <td
                                         onClick={(e) => {
                                             let a = e
-                                            document.getElementById('expandable-' + e.currentTarget.parentElement.id).classList.toggle("hide-expandable-row")
+                                            document.getElementById('expandable-' + data.id).classList.toggle("hide-expandable-row")
                                         }}
                                     >
                                         <IconLoader
diff --git a/src/hooks/urlBuilder.js b/src/hooks/urlBuilder.js
index 5adf6a1..d615dfb 100644
--- a/src/hooks/urlBuilder.js
+++ b/src/hooks/urlBuilder.js
@@ -63,9 +63,9 @@ export default function urlBuilder(
         pk = params.pk
     }
 
-    if( ! module && path_directories[0] == 'settings' ) {
+    if( ! module ) {
 
-        module = 'settings'
+        module = path_directories[0]
 
     }
 
@@ -75,12 +75,10 @@ export default function urlBuilder(
 
     }
 
-
     const allowed_actions = [ 'add', 'delete', 'edit' ]
 
     if( ! allowed_actions.includes( action ) ) {
 
-        action = null
 
         for( let dir of path_directories ) {
 
@@ -90,6 +88,12 @@ export default function urlBuilder(
         }
     }
 
+    if( ! action && path_directories[path_directories.length-1] == 'history' ) {
+
+        action = 'history'
+    }
+
+
     const ticket_models = [
         'change',
         'incident',
@@ -294,6 +298,9 @@ export default function urlBuilder(
 
         method = 'PATCH'
 
+    } else if( action === 'history' ) {
+
+        url += '/history'
     }
 
     if(
diff --git a/src/layout/history.jsx b/src/layout/history.jsx
index 6c0d84a..fe08fd0 100644
--- a/src/layout/history.jsx
+++ b/src/layout/history.jsx
@@ -22,7 +22,7 @@ const History = ({
             <div className="content">
                 <Table
                     callback={setContentHeading}
-                    data_url_path={'core/' + url_builder.model + '/' + url_builder.pk + '/history'}
+                    data_url_path={'core/' + url_builder.params.model + '/' + url_builder.params.pk + '/history'}
                 />
             </div>
         </section>