From 989cb6aa1443f711136f2c9d464ff902a5d25e86 Mon Sep 17 00:00:00 2001 From: Ary Borenszweig Date: Wed, 18 Dec 2024 14:36:18 -0300 Subject: [PATCH] Explain why the error we produce isn't very informative --- compiler/noirc_frontend/src/hir/comptime/interpreter.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/compiler/noirc_frontend/src/hir/comptime/interpreter.rs b/compiler/noirc_frontend/src/hir/comptime/interpreter.rs index fecf7fda022..e9e37243e07 100644 --- a/compiler/noirc_frontend/src/hir/comptime/interpreter.rs +++ b/compiler/noirc_frontend/src/hir/comptime/interpreter.rs @@ -575,6 +575,8 @@ impl<'local, 'interner> Interpreter<'local, 'interner> { match &global_info.value { GlobalValue::Resolved(value) => Ok(value.clone()), GlobalValue::Resolving => { + // Note that the error we issue here isn't very informative (it doesn't include the actual cycle) + // but the general dependency cycle detector will give a better error later on during compilation. let location = self.elaborator.interner.expr_location(&id); Err(InterpreterError::GlobalsDependencyCycle { location }) }