chore: Separate unconstrained functions during monomorphization #6894
Conversation
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Peak Memory Sample
|
Compilation Sample
|
Execution Sample
|
| @@ -276,19 +271,12 @@ pub fn create_program( | |||
| (generated_acirs, generated_brillig, brillig_function_names, error_types), | |||
| ssa_level_warnings, | |||
| ) = optimize_into_acir(program, options)?; | |||
| if options.force_brillig_output { | |||
There was a problem hiding this comment.
I do think this assert is correct and should remain.
There was a problem hiding this comment.
I'd rather remove the force_brillig option from SSA entirely since otherwise it'd only be used for this one assert
There was a problem hiding this comment.
We could remove the option but case on whether we have a single main function that is marked unconstrained
There was a problem hiding this comment.
As otherwise we are going to error out when asserting the number of acir artifacts against the number of function signatures.
There was a problem hiding this comment.
We can also just update how we collect function sigs
is_entry_point is going to return true for functions marked with #[fold]. However, if we are force compiling to Brillig we do not need to collect this signature. The func sigs are only used for constructing acir artifacts. This feels like the best solution here.
Description
Problem*
Resolves #6841
Summary*
Adds a boolean is_unconstrained as an extra key during monomorphization. This should separate constrained from unconstrained functions. This key is infectious so every function called from an unconstrained function will also be unconstrained.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.