Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow specifying multiple patterns in nargo test #7186

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

asterite
Copy link
Collaborator

Description

Problem

Resolves #7150

Summary

For this, no need to do nargo test -- one two, just doing nargo test one two works.

Additional Context

Also adds a space before "..." in nargo test output for each test because otherwise double-clicking the name would include the trailing "..." and copying that after nargo test wouldn't find the test. This is now the same as the output of cargo test.

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@asterite asterite changed the title Ab/nargo test multiple feat: allow specifying multiple patterns in nargo test Jan 24, 2025
Copy link
Contributor

@michaeljklein michaeljklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though this could use a smoke test, e.g. generated in nargo_cli's build.rs

@TomAFrench TomAFrench added this pull request to the merge queue Jan 30, 2025
Merged via the queue into master with commit bd44e40 Jan 30, 2025
100 of 101 checks passed
@TomAFrench TomAFrench deleted the ab/nargo-test-multiple branch January 30, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple test names with nargo test
3 participants