-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nargo test -q
(or nargo test --format terse
)
#6776
Merged
Merged
+431
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compilation Sample
|
Peak Memory Sample
|
asterite
force-pushed
the
ab/nargo-test-machine-readable-output
branch
from
December 11, 2024 19:59
a4d7df8
to
94aabde
Compare
asterite
force-pushed
the
ab/nargo-test-machine-readable-output
branch
from
December 12, 2024 09:36
94aabde
to
df37a64
Compare
asterite
added
the
run-external-checks
Trigger CI job to run tests on external repos
label
Dec 12, 2024
asterite
force-pushed
the
ab/nargo-test-machine-readable-output
branch
from
December 12, 2024 10:23
fd0e854
to
04a53ea
Compare
aakoshh
reviewed
Dec 12, 2024
aakoshh
reviewed
Dec 12, 2024
aakoshh
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, nice to see it broken up!
TomAFrench
reviewed
Dec 12, 2024
It would be nice to change this to contain the Curiously even though it fails on another PR that one has a green status. Maybe we don't want to be blocked by other repos checking in broken code? |
vezenovm
reviewed
Dec 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made on top of #6728
Problem
Towards #6733
Summary
Eventually we'll have
nargo test --format json
, which is what #6733. As a first step I wanted to introduce theformat
flag and, to try that abstraction in code I introduced a terse formatter similar to Rust.On failure we don't immediately print the error. Instead, it's printed at the end (like in Rust). I can imagine this could be used in CI to reduce the output verboseness, because I guess all that matters in CI is seeing which tests failed. NOTE: I already added this
-q
flag to our external checks, you can see how it looks, I think it's a bit better as it's less noisy.Like in Rust, there are two ways to trigger this terse behavior:
-q
(or--quiet
) or--format terse
. We could just keep--format terse
but I think-q
is convenient (andformat
is more general as it will soon supportjson
).Here's the output when all tests pass:
Additional Context
nargo test
insidenoir_stdlib
for a while now so we can probably move those to a CI test matrix (in this PR I tried to reuse the code fromnargo_cli
but I couldn't becausenargo_cli
is a binary and we can't use that binary as a dependency in test integrations).Documentation
Check one:
PR Checklist
cargo fmt
on default settings.