Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last size in an IAT column for IAT_SIZE feature #15

Open
yuming-l2 opened this issue Oct 23, 2022 · 1 comment
Open

Last size in an IAT column for IAT_SIZE feature #15

yuming-l2 opened this issue Oct 23, 2022 · 1 comment

Comments

@yuming-l2
Copy link

IAT_SIZE feature matrix will put the last size in the same column as IATs.

I guess it would be better to have iats_sizes.extend([sizes[j], iats[j]])

https://github.com/chicago-cdac/netml/blob/bae0e24240a7c82e8c63ef3a0e5f9fbd6d0eeff4/src/netml/pparser/parser.py#L413-L415

@feamster
Copy link
Member

Thanks! Is your rationale just so that the the column names match the name "IAT_SIZE"? Trying to figure out if this is a bug or simply an enhancement. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants