You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Replace custom signing process in scripts/signer.go and update.go with well established format. Maybe even replace scripts/signer.go with the corresponding cli in the Makefile and implement verification in update.go
Just found golang/go#44226 which sadly states that the usage of the openpgp module for go is discouraged. Will need to look a little deeper into the matter and search for alternatives or even just a change in naming so it is more obvious how to use the signature.
It's actively maintained. I found another replacement, but this onewasn't. So I suggest we avoid using PGP or GPG and go for ECDSA. There is a good article explaining how to implement it online and I'd like to implement it if we go forward with this solution. I believe it's a good choice: If it wasn't, lots of people would be at risk of losing lots of money.
I found that it also implements Ed25519, which according to this article is more secure. This is the algorithm we currently use. I also suggest we could pick this one to make things easier. Both algorithms bring good levels of security.
In case there are any incompatibilities, the current verification scheme and the new one could cohabit for a few months while people update their version of NoiseTorch. This will avoid new issues like #319. If we have to go this way, a message telling users to update as soon as possible should be displayed.
The latest release of Go allows to run .go files as scripts, for example go script signature.go noisetorchbinarypath which should be user friendly.
Replace custom signing process in
scripts/signer.go
andupdate.go
with well established format. Maybe even replacescripts/signer.go
with the corresponding cli in theMakefile
and implement verification inupdate.go
See #310 for example of why the current process is not optimal since the existance of the signature file is now more apparent.
The text was updated successfully, but these errors were encountered: