Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project alive? #3

Open
stanislaw55 opened this issue Jun 26, 2020 · 7 comments
Open

Is this project alive? #3

stanislaw55 opened this issue Jun 26, 2020 · 7 comments

Comments

@stanislaw55
Copy link

Hi,
I just want to ask about this project status. cert-manager/cert-manager#2288 is already merged in cert-manager and README is not updated yet. Also, I haven't seen any new development recently

@SimeonPoot
Copy link

seems to be stopped, 7months of no activity. I've forked the repo a while ago and made it working. You can check it out.
Will create a PR, when I'm finished.

@stanislaw55
Copy link
Author

Hi @SimeonPoot,
thanks for answer. I definitely take a look.

@makeacode
Copy link

I've just yesterday got your fork working within my EKS cluster. I had a serious problem of infinite looping when using cert-manager 1.16.0 helm chart, but after upgrade to 1.16.1 all is good...thanks much.

@SimeonPoot
Copy link

SimeonPoot commented Aug 26, 2020

What seemed to be the fix? Was it in cert-manager itself? Next step before I will create a PR to this repo is to get the template variable on the issuer. In stead of within the controller-manager.
Ps! Good to know to update to 1.16.1!

@makeacode
Copy link

I believe the only change i made was the upgrade to 1.16.1 because it definitely wasn't working before that. I just started messing with the ingress-shim and that doesn't seem to work... the following annotations

cert-manager.io/cluster-issuer: rootca
cert-manager.io/issuer-kind: "ClusterAdcsIssuer"
cert-manager.io/issuer-group: "adcs.certmanager.csf.nokia.com"

results in the following error:

E0826 17:21:14.389154 1 sync.go:54] cert-manager/controller/ingress-shim "msg"="failed to determine issuer to be used for ingress resource" "error"="both \"cert-manager.io/cluster-issuer\" and \"cert-manager.io/issuer-group\" may not be set, both \"cert-manager.io/cluster-issuer\" and \"cert-manager.io/issuer-kind\" may not be set" "resource_kind"="Ingress" "resource_name"="test-certificate" "resource_namespace"="docker-registry"

if I make the changes it suggests and remove the issuer-group and issuer-kind it generates the Certificate instance with the incorrect Group and Kind settings (as you might expect):

  Issuer Ref:
    Group:      cert-manager.io
    Kind:       ClusterIssuer
    Name:       rootca

removing the cluster-issuer and leaving the issuer-group and issuer-kind properties doesn't seem to do anything

@makeacode
Copy link

Ok....I figured out my problem...do not use the cluster-issuer even though it feels like you should. The following settings DO work:

cert-manager.io/issuer: rootca
cert-manager.io/issuer-kind: "ClusterAdcsIssuer"
cert-manager.io/issuer-group: "adcs.certmanager.csf.nokia.com"

@SimeonPoot
Copy link

Nice one. I had to figure that out too. Maybe good idea to catch it in the Readme.
Haven't got the custom ingress-certmanager annotations working with the ADCS-issuer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants