From 7ac614ec05f5f7b0536ac5b09e32a6064f51ceb1 Mon Sep 17 00:00:00 2001 From: Tushar Rathod <111466464+trathod1@users.noreply.github.com> Date: Thu, 27 Jul 2023 23:45:27 -0400 Subject: [PATCH] GNMI-1.10 Based on discussion in PR-1720 and b/283934938, removing manufacturer name validation for CPU. (#1875) "This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind." --- .../telemetry_basic_check_test/telemetry_basic_check_test.go | 5 ----- .../telemetry_basic_check_test/telemetry_basic_check_test.go | 5 ----- 2 files changed, 10 deletions(-) diff --git a/feature/gnmi/ate_tests/telemetry_basic_check_test/telemetry_basic_check_test.go b/feature/gnmi/ate_tests/telemetry_basic_check_test/telemetry_basic_check_test.go index fe9f1ade120..ceb73b27fd2 100644 --- a/feature/gnmi/ate_tests/telemetry_basic_check_test/telemetry_basic_check_test.go +++ b/feature/gnmi/ate_tests/telemetry_basic_check_test/telemetry_basic_check_test.go @@ -533,11 +533,6 @@ func TestCPU(t *testing.T) { for _, cpu := range cpus { t.Logf("Validate CPU: %s", cpu) component := gnmi.OC().Component(cpu) - if !gnmi.Lookup(t, dut, component.MfgName().State()).IsPresent() { - t.Errorf("component.MfgName().Lookup(t).IsPresent() for %q: got false, want true", cpu) - } else { - t.Logf("CPU %s MfgName: %s", cpu, gnmi.Get(t, dut, component.MfgName().State())) - } if !gnmi.Lookup(t, dut, component.Description().State()).IsPresent() { t.Errorf("component.Description().Lookup(t).IsPresent() for %q: got false, want true", cpu) } else { diff --git a/feature/gnmi/otg_tests/telemetry_basic_check_test/telemetry_basic_check_test.go b/feature/gnmi/otg_tests/telemetry_basic_check_test/telemetry_basic_check_test.go index 2d442f50cc6..57d9f108b8f 100644 --- a/feature/gnmi/otg_tests/telemetry_basic_check_test/telemetry_basic_check_test.go +++ b/feature/gnmi/otg_tests/telemetry_basic_check_test/telemetry_basic_check_test.go @@ -536,11 +536,6 @@ func TestCPU(t *testing.T) { for _, cpu := range cpus { t.Logf("Validate CPU: %s", cpu) component := gnmi.OC().Component(cpu) - if !gnmi.Lookup(t, dut, component.MfgName().State()).IsPresent() { - t.Errorf("component.MfgName().Lookup(t).IsPresent() for %q: got false, want true", cpu) - } else { - t.Logf("CPU %s MfgName: %s", cpu, gnmi.Get(t, dut, component.MfgName().State())) - } if !gnmi.Lookup(t, dut, component.Description().State()).IsPresent() { t.Errorf("component.Description().Lookup(t).IsPresent() for %q: got false, want true", cpu) } else {