Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual rendering #452

Open
nolanlawson opened this issue Sep 9, 2024 · 1 comment
Open

Virtual rendering #452

nolanlawson opened this issue Sep 9, 2024 · 1 comment
Labels
enhancement New feature or request performance

Comments

@nolanlawson
Copy link
Owner

#444 raised the issue of performance suffering when there are a lot of custom emoji (~20k). Some recent perf improvements addressed this using a combination of content-visibility and IntersectionObserver, which is great as a quick fix but doesn't address the root problem of needing to render ~20k DOM nodes.

The only solution to that is rendering a real virtual list. Unfortunately this has complexity and accessibility considerations, so it's not straightforward to implement. It might make sense, though, especially since some use cases (e.g. a massive Slack/Discord channel, a big Mastodon instance) might have even more than 20k custom emoji.
@nolanlawson nolanlawson added enhancement New feature or request performance labels Sep 9, 2024
@nolanlawson
Copy link
Owner Author

BTW I'm not 100% sold on this (due to the complexity/accessibility issues), but it's definitely worth considering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nolanlawson