cache not release

[shixued]

PromiseWorker.prototype.postMessage = function (userMessage) {
  var self = this
  var messageId = messageIds++

  var messageToSend = [messageId, userMessage]

  return new Promise(function (resolve, reject) {
    self._callbacks[messageId] = function (error, result) {
      if (error) {
        return reject(new Error(error.message))
      }
      resolve(result)
    }

    /* istanbul ignore if */
    if (typeof self._worker.controller !== 'undefined') {
      // service worker, use MessageChannels because e.source is broken in Chrome < 51:
      // https://bugs.chromium.org/p/chromium/issues/detail?id=543198
      var channel = new MessageChannel()
      channel.port1.onmessage = function (e) {
        onMessage(self, e)
      }
      self._worker.controller.postMessage(messageToSend, [channel.port2])
    } else {
      // web worker
      self._worker.postMessage(messageToSend)
    }
  })
}

when userMessage is Object，the var messageToSend = [messageId, userMessage] Causing object references not to be released.

[nolanlawson]

Thanks for reporting! The object should be freed when the message is sent back – you can see here that the callback is cleared:

promise-worker/index.js

Line 23 in 8856848

delete self._callbacks[messageId]

Do you have a reproducible test showing that memory is not freed when it should be freed?