Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom file names for primary and secondary stem #89

Open
JackismyShephard opened this issue Jul 17, 2024 · 4 comments
Open

Support custom file names for primary and secondary stem #89

JackismyShephard opened this issue Jul 17, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@JackismyShephard
Copy link

JackismyShephard commented Jul 17, 2024

I seem to recall this project supporting custom file names for primary and secondary stem in an earlier version, but it does not seem to be supported in the latest version (0.17.5). Would it be possible to bring that functionality back?

I am using this project as a python library for another project, which requires a specific naming scheme for output stems, so that functionality would be greatly appreciated.

@beveradb
Copy link
Collaborator

Hey, sorry, I ditched that functionality once I implemented support for models which output multiple stems and stems of different types as it was messy and hard to make it consistent.

The output from output_files = separator.separate(args.audio_file) should give you a list of filenames though so it should be easy to rename them to whatever you want in literally one more line of python code afterwards, e.g.

output_files = separator.separate(args.audio_file)
output_files[0].rename('instrumental.flac')
output_files[1].rename('vocals.flac')

Hope that's ok!

@JackismyShephard
Copy link
Author

JackismyShephard commented Jul 17, 2024

@beveradb Yes, that is more or less what I am doing now. Renaming manually is not a big problem, but being able to supply custom filenames to Separator.separate would still be a nice feature 😊

@JackismyShephard
Copy link
Author

JackismyShephard commented Jul 17, 2024

@beveradb Also, great work on this project. I was looking for an interface to programmatically access the functionality of UVR and the abstractions in your API expose it in both a comprehensive and intuitive way. Also, I appreciate your thorough documentation (although perhaps there could be more type annotations in the source code)

@beveradb
Copy link
Collaborator

beveradb commented Jul 17, 2024

Glad you appreciate it, and understood! PRs very welcome for both file renaming and type hints 😉

@beveradb beveradb added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants