From e6c2a616f045b9cd80f865936d799df5622f299e Mon Sep 17 00:00:00 2001 From: Richard Guo Date: Thu, 24 Oct 2024 09:18:41 -0700 Subject: [PATCH] For of instead of in fix (#166) > [!IMPORTANT] > Fix loop iteration in `domain()` function of `Deeptable` class from `for...in` to `for...of`. > > - **Behavior**: > - Fix loop iteration in `domain()` function of `Deeptable` class from `for...in` to `for...of` for iterating over `subfield` array. > > This description was created by [Ellipsis](https://www.ellipsis.dev?ref=nomic-ai%2Fdeepscatter&utm_source=github&utm_medium=referral) for c33efd4a1033e7098be40a2feb02df68ad89d7b9. It will automatically update as commits are pushed. --- src/Deeptable.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Deeptable.ts b/src/Deeptable.ts index eaabeb483..d78066c39 100644 --- a/src/Deeptable.ts +++ b/src/Deeptable.ts @@ -364,7 +364,7 @@ export class Deeptable { // First -- look at the schema metadata. let dim = this._schema?.fields.find((d) => d.name === columnName); - for (const sub in subfield) { + for (const sub of subfield) { if (dim === undefined) { continue; }