Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support recording method calling another recording method #3

Open
mkotsbak opened this issue Jun 4, 2010 · 4 comments
Open

Support recording method calling another recording method #3

mkotsbak opened this issue Jun 4, 2010 · 4 comments
Labels

Comments

@mkotsbak
Copy link
Contributor

mkotsbak commented Jun 4, 2010

Typically happens when you call internal private methods and set recording at class level.

Quickfix is probably to exclude recordings on private methods. Better is probably not to start a new recording if a recording in already going on.

@oc
Copy link
Member

oc commented Jun 7, 2010

I think the quickfix is the right fix!

This means public, friendly (package-local, package-private, (friendly is; and has many names:)) and protected methods in the first place?

The characterization should normally be the methods used by others :)

@mkotsbak
Copy link
Contributor Author

mkotsbak commented Jun 7, 2010

Well, I doubt the quickfix is any quicker. I think it will be as easy to just let the ongoing recording continue if we hit a recording method when already recording, and it might solve other similar issues.

@oc
Copy link
Member

oc commented Jun 7, 2010

I think I misunderstood the issue, I agree it might be better to just record one at a time, however that might not capture obscure usages of static/mutable state, etc if we isolate the recordings (?). I guess we should not put too much mind into optimizing this just yet. :)

@mkotsbak
Copy link
Contributor Author

mkotsbak commented Jun 7, 2010

I think we fast will get some data on the actual cases if we get a usable version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants