Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document using a local redis instead of Upstash #331

Closed
Erb3 opened this issue Oct 26, 2023 · 3 comments
Closed

Document using a local redis instead of Upstash #331

Erb3 opened this issue Oct 26, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Erb3
Copy link
Contributor

Erb3 commented Oct 26, 2023

Is your feature request related to a problem? Please describe.
When selfhosting, one may want to use a local redis instance instead of Upstash. It works flawlessly to host a redis server (or redis API compatible), and setting the UPSTASH_REDIS_REST_URL to 127.0.0.1, or the IP of the redis instance. The UPSTASH_REDIS_REST_TOKEN can be left empty, but you need to update src/env.mjs to allow the UPSTASH_REDIS_REST_TOKEN to be empty.

UPSTASH_REDIS_REST_TOKEN: z.string().min(0),

Describe the solution you'd like
I would like CONTRIBUTING.md to document the usage of a local redis instance.

Describe alternatives you've considered
A different solution would be to make redis optional, since it is only used for rate limiting. If noodle is only exposed to LAN, rate limiting is not a big concern.

Additional context
See Discord conversation about redis.

@Erb3 Erb3 added the enhancement New feature or request label Oct 26, 2023
@YoussefLaunchUp
Copy link
Contributor

I would love to see Redis made optional as well. Would make development easier.

@YoussefLaunchUp
Copy link
Contributor

This PR has look at this plus just making it fully optional.
#333

@Erb3
Copy link
Contributor Author

Erb3 commented Nov 4, 2023

Fixed in #333

@Erb3 Erb3 closed this as completed Nov 4, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noodle's roadmap to glory Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants