Convert various sync calls to async #7287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shane32
commented
Aug 8, 2024
Comment on lines
+677
to
+680
| public static IAsyncEnumerable<T> ToAsyncEnumerable<T>(this IQueryable<T> source) | ||
| { | ||
| return AsyncExtensions.AsAsyncEnumerable(source); | ||
| } |
There was a problem hiding this comment.
The existing calls to ToAsyncEnumerable(IEnumerable) were simply wrapping an IEnumerable into an IAsyncEnumerable wrapper and were not asynchronous. LinqToDb provides the AsAsyncEnumerable method to properly convert a IQueryable to IAsyncEnumerable. This new method has a tighter scope (accepting a IQueryable) and receives precedence from the compiler.
|
Hi @Shane32. Thank you very much for your help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Shane32.Analyzers NuGet package, all implicit casts of
IQuerabletoIEnumerablecan be detected and fixed. This PR does not add the NuGet package, but fixes many of the detected errors.I did not attempt to fix errors within synchronous methods, such as within data migration classes.