Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window divider foreground vs background #80

Open
gongzhitaao opened this issue Dec 2, 2019 · 1 comment
Open

window divider foreground vs background #80

gongzhitaao opened this issue Dec 2, 2019 · 1 comment

Comments

@gongzhitaao
Copy link

gongzhitaao commented Dec 2, 2019

https://github.com/arcticicestudio/nord-emacs/blob/52756cdc909b29691eef228897b3de561cd99f43/nord-theme.el#L322

Setting :background as in the code gives me

background

Notice the white divider line above the minibuffer.

Setting :foreground gives me:

foreground

So I think the code should be

`(window-divider ((,class (:foreground ,nord3))))
`(window-divider-first-pixel ((,class (:foreground ,nord3))))
`(window-divider-last-pixel ((,class (:foreground ,nord3))))
@arcticicestudio
Copy link
Contributor

Hi @gongzhitaao 👋, thanks for your contribution 👍
Great catch, this is a small but noticeable detail. I'll test the changes in the near future, but feel free to submit a PR if you like 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants