Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Color Brightness Doesn't Apply #222

Closed
hwair opened this issue Aug 15, 2020 · 3 comments
Closed

Comment Color Brightness Doesn't Apply #222

hwair opened this issue Aug 15, 2020 · 3 comments

Comments

@hwair
Copy link

hwair commented Aug 15, 2020

Using: gnome-terminal + tmux + nvim.
From nordtheme/nord#94, it was seen that nord3 was updated from #4C566A to #616E88.
In my v0.15.0 ~/.vim/plugged/nord-vim/colors file, these lines are present:

let s:nord3_gui = "#4C566A"
let s:nord3_gui_bright = "#616E88"

However, the comment colors are still the darker version:
image
I am certain that the aforementioned file is the one controlling the colors, as moving it resets neovim to the default color scheme.
I have tried copying the file found here https://github.com/arcticicestudio/nord-vim/blob/develop/colors/nord.vim into my colors file, but there was no change. Nor does changing the values of s:nord3_gui or s:nord3_gui_bright to colors like #FF0000 do anything.
How can I get the brighter comment color? If editing the file doesn't work, can I change the setting from .vimrc instead?

@arcticicestudio
Copy link
Contributor

Hi @EvasiveUmbrella 👋

In order to ensure the problem is related to the Nord theme you need to reproduce it with a minimal and clean configuration. This can be done by creating new configuration file with any name (e.g. testrc) and run Vim with the following command: vim -u testrc
For me as a theme author it is not possible to know if the theme is the root cause of the problem when there are other attributes set in the configuration because each one might break the theme.

Here's an minimal test configuration you can use to try to reproduce the problem (supposed you're using vim-plug):

call plug#begin(expand('~/.vim/plugged'))
Plug 'arcticicestudio/nord-vim'
call plug#end()

set nocompatible
if (has("termguicolors"))
  set termguicolors
endif

syntax enable
colorscheme nord

As you can see in the example configuration I've added the termguicolors settings which could be one reason why the color is not rendered. This is because, like described in nordtheme/nord#94, the actual color palette hasn't changed but only ports that are targeted to applications with syntax highlighting. The *_term attributes make use of the colors that are provided by the terminal color scheme which is Nord GNOME Terminal in your case. The *_gui variables on the other side are used when Vim runs in GUI mode and when the termguicolors is set and the terminal supports “true colors“ (24bit).

Please try to either use the example configuration or set the termguicolors setting in your current configuration.

@hwair
Copy link
Author

hwair commented Aug 20, 2020

image
Perfect, thank you very much!
In hindsight, the _gui suffix should have been a clear indication of my error

@hwair hwair closed this as completed Aug 20, 2020
@arcticicestudio
Copy link
Contributor

Nice to see it works for you now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants