-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color for tree.indentGuidesStroke
#145
Comments
Hi @octref 👋, thanks for your contribution 👍 Also the idea of having a tool to check for missing rules is awesome 💯 |
The issue I see with nord3 is that on hover, VS Code will take a dimmed color of the key, and nord3 is a bit too low contrast... I hope a sensible default can be chosen for Nord, but I'll still likely use the color for open folder https://raw.githubusercontent.com/ayu-theme/vscode-ayu/master/icons/folder_opened_dark%402x.png so it's consistent with the icon colors.
I didn't see the comment 😅Maybe you forgot to post? |
Oh the The comment should be visible now, haven't got time to finish it before leaving for work. |
VS Code 1.36.0 (1) June 2019 introduced support for indent guide lines in the tree view (2). To adapt to Nord's style and ensure it is still distinguishable from the background when hovering with the mouse, the new brightened comment color based on ` nord3` (GH-118) is used. References: (1) https://code.visualstudio.com/updates/v1_36 (2) https://code.visualstudio.com/updates/v1_36#_tree-indent-guides GH-145
VS Code 1.36.0 (1) June 2019 introduced support for indent guide lines in the tree view (2). To adapt to Nord's style and ensure it is still distinguishable from the background when hovering with the mouse, the new brightened comment color based on ` nord3` (GH-118) is used. References: (1) https://code.visualstudio.com/updates/v1_36 (2) https://code.visualstudio.com/updates/v1_36#_tree-indent-guides Resolves GH-145
🚢 Shipped with extension release version 🏷 0.11.0. |
In the upcoming release, VS Code will add indentation guides in File Explorer. See microsoft/vscode#17777 for details.
A new key
tree.indentGuidesStroke
will be added. It doesn't look nice in Nord yet:So I tried
Please consider adding a color for
tree.indentGuidesStroke
. Thanks!The text was updated successfully, but these errors were encountered: