Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook color tokens for cells, borders and focus states #201

Open
arcticicestudio opened this issue Jun 20, 2021 · 2 comments
Open

Notebook color tokens for cells, borders and focus states #201

arcticicestudio opened this issue Jun 20, 2021 · 2 comments

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jun 20, 2021

VS Code 1.47 (June 2020) introduced new theme color tokens for Notebooks cells, borders and focus states.

The following token will be added to make it more conform with Nord's style:

  • notebook.cellBorderColor — the border color for Notebook cells.
  • notebook.cellHoverBackground — the background color of a cell when the cell is hovered.
  • notebook.cellInsertionIndicator — the color of the Notebook cell insertion indicator.
  • notebook.focusedCellBackground — the background color of a cell when the cell is focused.
  • notebook.focusedCellBorder — the color of the cell's top and bottom border when the cell is focused.
  • notebook.focusedCellShadow — the color of the cell shadow when cells are focused.
  • notebook.focusedEditorBorder — the color of the Notebook cell editor border.
@roosephu
Copy link

roosephu commented Oct 6, 2022

The default notebook.focusedCellBorder is hard to recognize so I'm using this: "notebook.focusedCellBorder": "#81A1C1",

Before:
image
After:
image

@svengreb
Copy link
Member

It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added for triage in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: triage
Development

No branches or pull requests

3 participants