Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment text is not very visible in added diff view #61

Closed
octref opened this issue Nov 27, 2017 · 2 comments
Closed

Comment text is not very visible in added diff view #61

octref opened this issue Nov 27, 2017 · 2 comments
Labels
context-config context-syntax resolution-user-side scope-customization type-support

Comments

@octref
Copy link
Contributor

octref commented Nov 27, 2017

image

If this cannot be solved by changing some values in the existing schema, I can also open an issue on VS Code side to request a theme config for this case.
@arcticicestudio
Copy link
Contributor

I don't know any scope that could be used to adjust the comment color when shown in the diff view so unfortunately this is a edge case when using a customized brighter comment color. Using the default theme comment color works fine.

gh-61-default-theme-comment color

@octref
Copy link
Contributor Author

octref commented Dec 2, 2017

Just tried it, the default comment contrast is enough for me so I removed the customized comment color. Thanks!

@octref octref closed this as completed Dec 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-config context-syntax resolution-user-side scope-customization type-support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@octref @arcticicestudio @svengreb