Bugfix onProgress regex pattern trigger (~) #201
Conversation
Fixed Download Progress event on yt-dlp v2023.03.04 Before download info was: [download] 0.1% of 820.00MiB at 599.88KiB/s ETA 23:18 (frag 0/82) Now it prints as: [download] 0.1% of ~ 820.00MiB at 599.88KiB/s ETA 23:18 (frag 0/82)
src/YoutubeDl.php
Outdated
| @@ -36,7 +36,7 @@ | |||
|
|
|||
| class YoutubeDl | |||
| { | |||
| public const PROGRESS_PATTERN = '#\[download\]\s+(?<percentage>\d+(?:\.\d+)?%)\s+of\s+(?<size>[~]?\d+(?:\.\d+)?(?:K|M|G)iB)(?:\s+at\s+(?<speed>(\d+(?:\.\d+)?(?:K|M|G)iB/s)|Unknown speed))?(?:\s+ETA\s+(?<eta>([\d:]{2,8}|Unknown ETA)))?(\s+in\s+(?<totalTime>[\d:]{2,8}))?#i'; | |||
| public const PROGRESS_PATTERN = '#\[download\]\s+(?<percentage>\d+(?:\.\d+)?%)\s+of\s+(?<size>[~]?[\s+]?\d+(?:\.\d+)?(?:K|M|G)iB)(?:\s+at\s+(?<speed>(\d+(?:\.\d+)?(?:K|M|G)iB/s)|Unknown speed))?(?:\s+ETA\s+(?<eta>([\d:]{2,8}|Unknown ETA)))?(\s+in\s+(?<totalTime>[\d:]{2,8}))?#'; | |||
There was a problem hiding this comment.
Typo. Copy and Paste from regex debugger.
Fixed Download Progress event on yt-dlp v2023.03.04 Before download info was: [download] 0.1% of ~820.00MiB at 599.88KiB/s ETA 23:18 (frag 0/82) Now it prints as: [download] 0.1% of ~ 820.00MiB at 599.88KiB/s ETA 23:18 (frag 0/82)
|
Put back /i modifier on regex by a mislead typo. |
Fix Fatal error on redo Finished Downloads
Fix trigger onProgress [~] another variations
CS Fix
|
@unilogica are you willing to add the test? :) |
Sure. I will do that in this Saturday |
|
yt-dlp is up to date ([email protected]) What is wrong for me? |
|
New yt-dlp update, new regex for anyone having this issue again. |
|
@UnicodeApocalypse so why not submitting a Pull request? :) |
|
So are is there anyone who is willing to finish this? |
Fixed Download Progress event on yt-dlp v2023.03.04
Before download info was:
[download] 0.1% of ~820.00MiB at 599.88KiB/s ETA 23:18 (frag 0/82)
Now it prints as:
[download] 0.1% of ~ 820.00MiB at 599.88KiB/s ETA 23:18 (frag 0/82)
Closes #200