Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID fields are assumed to be unique #7

Open
norman-tom opened this issue Nov 3, 2023 · 0 comments
Open

ID fields are assumed to be unique #7

norman-tom opened this issue Nov 3, 2023 · 0 comments

Comments

@norman-tom
Copy link
Owner

Pyromb assumes that the id field for reaches, confluences and centroids are globally unique. The dictionary that holds the ids to map these to an integer id required by RORB is shared across the three entities, therefore when these ids are not globally unique the order of connection is disrupted and RORB fails to build the catg file.

Solution is to use separate dictionaries, one for the reaches, confluences and centroids and only require unique ids within each dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant