Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contiribute documentation referes to makefile targets that don't exist #862

Open
nemith opened this issue Sep 21, 2023 · 1 comment
Open

Comments

@nemith
Copy link
Contributor

nemith commented Sep 21, 2023

I was reading through the contibution documenation here https://nornir.readthedocs.io/en/latest/contributing/index.html#starting-development-environment and it mentions a developer environment as well as a docker-compose dependency handling.

It states:

Some tests requires additional services to be running which are managed by docker-compose. You can start these services with:
make start_dev_env

Seems like these were removed in #562 but the documentation wasn't reflected.

@dbarrosop
Copy link
Contributor

Yes, that needs updating. Since we separated core from plugins into different repositories there is no need for docker containers to test the core of nornir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants