Redmine 4.0 support #45
Comments
|
I've been playing a little bit with this: Since diff --git a/Gemfile b/Gemfile
index 88fa2de..caaf4ba 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,3 +1,4 @@
+gem 'protected_attributes_continued'
gem 'roo'
gem 'iconv'
group :test, :development do
diff --git a/app/controllers/vault_settings_controller.rb b/app/controllers/vault_settings_controller.rb
index 748454b..aaf25f2 100644
--- a/app/controllers/vault_settings_controller.rb
+++ b/app/controllers/vault_settings_controller.rb
@@ -6,7 +6,7 @@ class VaultSettingsController < ApplicationController
menu_item :vault_settings
layout 'admin'
- before_filter :require_admin
+ before_action :require_admin
def indexNow diff --git a/lib/project_patch.rb b/lib/project_patch.rb
index 8f7573b..cb7e929 100644
--- a/lib/project_patch.rb
+++ b/lib/project_patch.rb
@@ -4,7 +4,7 @@ require_dependency "#{Rails.root}/plugins/vault/lib/vault"
module ProjectPatch
def self.included(base)
base.class_eval do
- has_many :keys, class_name: Vault::Key
+ has_many :keys, class_name: Vault::Key.to_s
end
end
endThis changes allowed installing but every time I click on the Any ideas? |
|
Sure we will implement this compatibility |
|
gem 'protected_attributes_continued' would't solve all problems |
|
@noshutdown-ru-user any news on this issue, please? We are very eager to run Redmine 4 and this is our only blocker. Is there anything we can do to help? |
|
this is cool, then soon we will publish fix, hope in couple of days |
|
Is this related to v3.4 as well? Installed the plugin and when trying to access UI: /usr/lib/ruby/vendor_ruby/rails/application.rb:352:in |
it shouldn't, can you paste more env details ? |
|
you can try this branch |
|
Ah apologies and thank you! |
|
Thank you @noshutdown-ru-user, tomorrow I'll give it a try. |
|
Hi! Just tried the I tried again in a new project and got the following: |
|
Aha so problem only with existed keys ? |
|
Looks like the main problem is the same with both new (empty) projects and old projects (with keys) - Encryptor is inaccessible. |
|
Strange we tested it on clear installation by this repo: https://github.com/noshutdown-ru/vagrant_redmine |
|
I gave it a shot and I got the error (
|
|
Until there is an official fix available, I've replaced 2 lines in def encrypt!
- self.body = Encryptor::encrypt(self.body)
+ self.body = Redmine::Ciphering.encrypt_text(self.body).gsub(/\n/, '')
self
end
#TODO: all data should be stored in UTF-8
def decrypt!
- self.body = Encryptor::decrypt(self.body).force_encoding('UTF-8')
+ self.body = Redmine::Ciphering.decrypt_text(self.body).force_encoding('UTF-8')
self
endAs we are using I am not sure why the |
|
we fixed issues with |
|
Just pulled branch Great work! |
|
Works here too. So something is changed in Redmine 4.x and lib autoloading? |
|
I believe the correct Anyway, should this |
|
it quite strange because in development mode autoload working properly, we will check what different |
they no needed, but we will check |
|
we will check it |
|
Added small changes and merged to master |
Hi!
Are there any plans on supporting Redmine 4.0?
The text was updated successfully, but these errors were encountered: