Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin output size limitation #187

Open
JeyJeyGao opened this issue Nov 7, 2022 · 2 comments · May be fixed by #484 or notaryproject/specifications#320
Open

plugin output size limitation #187

JeyJeyGao opened this issue Nov 7, 2022 · 2 comments · May be fixed by #484 or notaryproject/specifications#320
Assignees
@JeyJeyGao
Milestone
Discuss

Comments

@JeyJeyGao
Copy link
Contributor

JeyJeyGao commented Nov 7, 2022 •
edited
Loading

The plugin is an external binary which may generate very large command line output and will be loaded to memory by notation-go library.
Do we need a plugin output size limitation?
@priteshbandi priteshbandi added this to the RC-2 milestone Nov 23, 2022
@yizha1 yizha1 modified the milestones: RC-2, Discuss Dec 14, 2022
@vaninrao10 vaninrao10 modified the milestones: Discuss, Future Nov 12, 2024
@vaninrao10
Copy link

We aligned in the community meeting on 11/11 and finalized that we need pursue with the limitation option. Further discussion how to solution is pending.
Customer should trust the plugin, all of the output should satisfy the requirement and not generate large content. Will it crash if the memory is overloaded. Document security best practices and customer need to define what is the size limit.

@vaninrao10 vaninrao10 modified the milestones: Future, Discuss Nov 12, 2024
@JeyJeyGao JeyJeyGao linked a pull request Nov 29, 2024 that will close this issue
Open
@JeyJeyGao
Copy link
Contributor Author

Tested on Linux. A very large plugin output triggers the OS to kill the process. We need to fix it.

@JeyJeyGao JeyJeyGao linked a pull request Dec 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeyJeyGao JeyJeyGao

Labels
None yet
Projects
Notary Project Planning Board
Status: Todo
Milestone
Discuss
4 participants
@priteshbandi @JeyJeyGao @yizha1 @vaninrao10