From ce9493a34d5ef6f496280c2b3e3ad84080d7ee66 Mon Sep 17 00:00:00 2001 From: Dave Shoup Date: Thu, 26 Oct 2023 11:51:01 -0400 Subject: [PATCH] remove symlink (#62) * changelog * remove symlinks --- CHANGELOG.md | 5 +++++ deno/base/1.37/Dockerfile | 4 ---- python/base/3.10/Dockerfile | 4 ---- python/base/3.11/Dockerfile | 4 ---- python/base/3.9/Dockerfile | 4 ---- r/base/4.3.0/Dockerfile | 4 ---- rust/base/1.70/Dockerfile | 4 ---- 7 files changed, 5 insertions(+), 24 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 86cd281..176e646 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## Unreleased + +### Removed +- Symlink between `/etc/noteable` (old) and `/var/run/noteable` (new) + ## [0.0.2] - 2023-09-20 ### Fixed - Fixed variable generation on release pipelines diff --git a/deno/base/1.37/Dockerfile b/deno/base/1.37/Dockerfile index f6f5765..5c75170 100644 --- a/deno/base/1.37/Dockerfile +++ b/deno/base/1.37/Dockerfile @@ -29,10 +29,6 @@ RUN groupadd --gid 4004 noteable && \ chown --recursive noteable:noteable "${NBL_HOME_DIR}" && \ mkdir -p "${NBL_WORK_DIR}" && chown --recursive noteable:noteable "${NBL_WORK_DIR}" -# TEMPORARY: symlink the previous /etc/noteable to the new NBL_WORK_DIR (/var/run/noteable) dir -# until all other services are migrated and the old /etc/noteable can be removed -RUN ln -s "${NBL_WORK_DIR}" /etc/noteable - WORKDIR /tmp COPY apt-install /usr/bin/ diff --git a/python/base/3.10/Dockerfile b/python/base/3.10/Dockerfile index 83b5f7e..84bf2e7 100644 --- a/python/base/3.10/Dockerfile +++ b/python/base/3.10/Dockerfile @@ -31,10 +31,6 @@ RUN groupadd --gid 4004 noteable && \ mkdir /opt/venv && chown noteable:noteable /opt/venv && \ mkdir /etc/ipython && chown noteable:noteable /etc/ipython -# TEMPORARY: symlink the previous /etc/noteable to the new NBL_HOME_DIR (/var/run/noteable) dir -# until all other services are migrated and the old /etc/noteable can be removed -RUN ln -s "${NBL_WORK_DIR}" /etc/noteable - WORKDIR /tmp # Install tini to manage passing signals to the child kernel process diff --git a/python/base/3.11/Dockerfile b/python/base/3.11/Dockerfile index 52291af..a661165 100644 --- a/python/base/3.11/Dockerfile +++ b/python/base/3.11/Dockerfile @@ -31,10 +31,6 @@ RUN groupadd --gid 4004 noteable && \ mkdir /opt/venv && chown noteable:noteable /opt/venv && \ mkdir /etc/ipython && chown noteable:noteable /etc/ipython -# TEMPORARY: symlink the previous /etc/noteable to the new NBL_WORK_DIR (/var/run/noteable) dir -# until all other services are migrated and the old /etc/noteable can be removed -RUN ln -s "${NBL_WORK_DIR}" /etc/noteable - WORKDIR /tmp # Install tini to manage passing signals to the child kernel process diff --git a/python/base/3.9/Dockerfile b/python/base/3.9/Dockerfile index 8a7c70f..2eebbaf 100644 --- a/python/base/3.9/Dockerfile +++ b/python/base/3.9/Dockerfile @@ -31,10 +31,6 @@ RUN groupadd --gid 4004 noteable && \ mkdir /opt/venv && chown noteable:noteable /opt/venv && \ mkdir /etc/ipython && chown noteable:noteable /etc/ipython -# TEMPORARY: symlink the previous /etc/noteable to the new NBL_WORK_DIR (/var/run/noteable) dir -# until all other services are migrated and the old /etc/noteable can be removed -RUN ln -s "${NBL_WORK_DIR}" /etc/noteable - WORKDIR /tmp # Install tini to manage passing signals to the child kernel process diff --git a/r/base/4.3.0/Dockerfile b/r/base/4.3.0/Dockerfile index 76c789c..5e45360 100644 --- a/r/base/4.3.0/Dockerfile +++ b/r/base/4.3.0/Dockerfile @@ -29,10 +29,6 @@ RUN groupadd --gid 4004 noteable && \ mkdir -p "${NBL_WORK_DIR}" && chown --recursive noteable:noteable "${NBL_WORK_DIR}" && \ chown --recursive noteable:noteable /usr/local/lib/R/site-library -# TEMPORARY: symlink the previous /etc/noteable to the new NBL_WORK_DIR (/var/run/noteable) dir -# until all other services are migrated and the old /etc/noteable can be removed -RUN ln -s "${NBL_WORK_DIR}" /etc/noteable - # Install tini to manage passing signals to the child kernel process ENV TINI_VERSION v0.19.0 ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini diff --git a/rust/base/1.70/Dockerfile b/rust/base/1.70/Dockerfile index dc9cbf4..7edb57e 100644 --- a/rust/base/1.70/Dockerfile +++ b/rust/base/1.70/Dockerfile @@ -28,10 +28,6 @@ RUN groupadd --gid 4004 noteable && \ chown --recursive noteable:noteable "${NBL_HOME_DIR}" && \ mkdir -p "${NBL_WORK_DIR}" && chown --recursive noteable:noteable "${NBL_WORK_DIR}" -# TEMPORARY: symlink the previous /etc/noteable to the new NBL_WORK_DIR (/var/run/noteable) dir -# until all other services are migrated and the old /etc/noteable can be removed -RUN ln -s "${NBL_WORK_DIR}" /etc/noteable - WORKDIR /tmp COPY apt-install /usr/bin/