Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide py.typed #102

Open
rgbkrk opened this issue Apr 25, 2023 · 0 comments
Open

Provide py.typed #102

rgbkrk opened this issue Apr 25, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@rgbkrk
Copy link
Contributor

rgbkrk commented Apr 25, 2023

Is your feature request related to a problem? Please describe.

When this package is used from a workspace that uses mypy it will show up with the error:

Skipping analyzing "origami": module is installed, but missing library stubs or py.typed marker 

You wrote all these types! Let's make them usable for anyone using the SDK.

Describe the solution you'd like

One of the options that mypy recommends: https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-library-stubs-or-py-typed-marker

Describe alternatives you've considered

I have to put this in my pyproject.toml for the moment:

[[tool.mypy.overrides]]
module = "origami.client"
ignore_missing_imports = true

[[tool.mypy.overrides]]
module = "origami.defs.rtu"
ignore_missing_imports = true

[[tool.mypy.overrides]]
module = "origami.defs.deltas"
ignore_missing_imports = true

[[tool.mypy.overrides]]
module = "origami.defs.files"
ignore_missing_imports = true

Additional context

💙

@rgbkrk rgbkrk added the enhancement New feature or request label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant