Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated API: client.Databases.RetrieveAsync #405

Open
matkoch opened this issue Nov 13, 2023 · 2 comments
Open

Deprecated API: client.Databases.RetrieveAsync #405

matkoch opened this issue Nov 13, 2023 · 2 comments
Labels
chore documentation Improvements or additions to documentation good first issue Good for newcomers
Milestone

Comments

@matkoch
Copy link

matkoch commented Nov 13, 2023

Describe the bug
API was deprecated

To Reproduce

var notionClient = NotionClientFactory.Create(new ClientOptions
            {
                AuthToken = "accessToken"
            }
var database = await notionClient.Databases.RetrieveAsync("");

Expected behavior
Getting information about the database.

@KoditkarVedant
Copy link
Contributor

@matkoch would you like to contribute? I would be happy to accept the PR.

@KoditkarVedant KoditkarVedant added documentation Improvements or additions to documentation good first issue Good for newcomers chore labels Dec 14, 2023
@Kuzmanov
Copy link
Contributor

Since it's not possible to get all databases from the databases endpoint, and it requires an Id, I think it makes sense to throw an ArgumentNullException when databaseId is not provided.

As an alternative, Notion suggests using the Search API

@KoditkarVedant KoditkarVedant added this to the 4.3.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants