-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows taskbar wrong/missing icon #13
Comments
can you please show a screenshot? i haven't seen this before. |
I was having the same problem on Linux (elementary OS 6.0, based on Ubuntu 20.04), but with the "regular" repackaged version, not the enhanced one. It was caused because the window class of the opened app was "notion-app", while the .desktop file declared it as "Notion". I fixed the following line on the .desktop file and it worked fine:
I believe the cause of this issue on Windows might be similar, however I don't know if there's an equivalent fix there. |
Could you do a screenshot or something to show where the .desktop file is? I'm a little new to this whole thing, so I'm having trouble finding it... |
Yep this is very annoying, I wonder if there is a fix for this |
@starryyskies the .desktop file is in this folder: Inside it you'll see the "StartupWMClass" line that you need to change to be like the one I sent on the previous comment. |
I tried the app on Windows and I didn't have this problem. Make sure you clean every trace of the original Notion (no shortcuts, maybe check registry, etc...) As for Linux users, where they had a bad .desktop file, this should be fixed in 2.0.16-2 (releasing now). EDIT: Released 2.0.16-2, should fix this issue for Linux users: |
I just did a clean install of Windows 10 on a VM so I could try reproduce it, but it just works for me. The icon is good, I can pin the app and restart it without it being detected as a different app, etc. Admittedly, I only installed Notion Enhanced, maybe having the official Notion app (or some of its remnants) causes this issue. |
@jamezrin I think there is a bug with the taskbar icon being misconfigured - when I open Notion enhanced, pin it, then close it and try reopen from the taskbar pin it opens the normal/unenhanced Notion app. Plus, it shows the Notion icon instead of the enhancer icon. I'm not sure if that's an electron-builder fix or something you want me to look into making a patch for some part of the app? |
I can't reproduce the issue, I get a different behavior, see this quick repro video: https://youtu.be/ulaBxIeHg5I I formatted my PC recently, so my registry is clean, I didn't install the original Notion exe. All I can think of is that the Notion installer leaves some entries in the registry messing up the handling of apps in the taskbar. |
That's probably what it is. There must be some way we can further separate the registry details for Notion from the registry details for Notion Enhanced, though, right? I'll have a look around the electron code a bit later and see if I spot anything. Repro video: https://www.youtube.com/watch?v=THS2bd6jGqo |
I was able to resolve the problem by going into |
The solution for me was as simple as pinning the app (by searching it in the menu) to my taskbar and opening it. I don't know how it works, but as I had several issues with notion-enhancer I had to install and uninstall notion several times. As I eventualy gave up (for the time), I found myself with se same problem. I checked the code and I assume it has to do with what @jacobhuesman said. |
Hiya,
Love the project, and the extra tweaks in this one compared to the base version are A++ awesome.
I'll be going back to the non-pre-enhanced version though for now.
My main issue (which I know sounds trivial, but it bugs me a LOT) is that if I pin Notion Enhanced to the taskbar in windows 10, the application shows up as a separate item. Doesn't happen with the non-repackaged version.
Keep up the good work.
The text was updated successfully, but these errors were encountered: