Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some helpers to middleware #49

Open
notrab opened this issue Sep 8, 2024 · 0 comments · May be fixed by #70
Open

Rename some helpers to middleware #49

notrab opened this issue Sep 8, 2024 · 0 comments · May be fixed by #70
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@notrab
Copy link
Owner

notrab commented Sep 8, 2024

We should rename the following Helpers to be Middleware instead, and follow the style of CacheMiddleware:

  • BasicAuth
  • BearerAuth
  • BodyLimit
  • CORS
  • Compress
  • RequestId
  • Logger

This would be a breaking change, but since we're still in early stages, I don't think this is a huge concern.
@notrab notrab added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 8, 2024
@lucasacoutinho lucasacoutinho linked a pull request Nov 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: rename helpers to middleware lucasacoutinho/dumbo
1 participant
@notrab