Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exception handling for orjson.dumps in send_message #11

Open
ayberkenis opened this issue Mar 10, 2023 · 1 comment
Open

add exception handling for orjson.dumps in send_message #11

ayberkenis opened this issue Mar 10, 2023 · 1 comment

Comments

@ayberkenis
Copy link
Contributor

send_message should raise a detailed exception instead of ClientRuntimeError

winerp/winerp/client.py

Lines 83 to 87 in 50718f0

async def send_message(self, data: Union[Any, WsMessage]):
if not isinstance(data, WsMessage):
data = data.__dict__
logger.debug(data)
await self.websocket.send(orjson.dumps(data).decode("utf-8"))

@AwesomeSam9523
Copy link
Collaborator

is this still not done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants