Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memacs_firefox output does not include url title #103

Open
japhir opened this issue Dec 1, 2020 · 7 comments
Open

memacs_firefox output does not include url title #103

japhir opened this issue Dec 1, 2020 · 7 comments

Comments

@japhir
Copy link

japhir commented Dec 1, 2020

in #87 this issue is mentioned for chrome, and in #98 @alex-a-soto fixed the chrome output by including a title url in the note's name.

It would be great if the firefox-backend also did this.

Furthermore it appears that the firefox script is adding a single space before all the lines after the ## -- coding: utf-8 mode: org -- line. I am running the AUR package and wrote the below script to run the package (it gives an error when firefox is running) and fix the first line issue.

#!/usr/bin/sh
pgrep -x firefox >/dev/null && echo "firefox is running" ||
        memacs_firefox -f /home/japhir/.mozilla/firefox/5sm2gv3t.default/places.sqlite | sed 's/^ \*/*/' > /home/japhir/org/memacs/mozhist.org_archive
@japhir japhir changed the title memacs_firefox output issues memacs_firefox output does not include url title Dec 1, 2020
@japhir
Copy link
Author

japhir commented Dec 1, 2020

it does look like the line

output = OrgFormat.link(params['url'], params['title'])
is identical though…

@novoid
Copy link
Owner

novoid commented Dec 2, 2020

There are multiple people who contributed to the Firefox module (and who probably are using it in contrast to me):
https://github.com/novoid/Memacs/commits/master/memacs/firefox.py

Does somebody volunteer for this issue?
@kidd @nguyenhaiac

@kidd
Copy link
Contributor

kidd commented Dec 8, 2020

Unfortunately I'm not using memacs anymore and I'm not sure when I'll have the time to test this up :(

@japhir
Copy link
Author

japhir commented Dec 8, 2020

I also decided that waiting for several seconds for my agenda to pop up is too annoying as yet, so this feature doesn't have priority for me.

@novoid
Copy link
Owner

novoid commented Dec 8, 2020

I also decided that waiting for several seconds for my agenda to pop up is too annoying as yet, so this feature doesn't have priority for me.

Well, Memacs does not affect your normal agenda performance at all when you generate Memacs data to archive files as described on https://github.com/novoid/Memacs/blob/master/docs/FAQs_and_Best_Practices.org#performance-and-scalability

@japhir
Copy link
Author

japhir commented Dec 9, 2020

Yes, I know, but for what I would actually use it: to look at what I was doing on a particular day/time, it does slow down the archive view massively. I hadn't realized before looking into this endeavour that your loading times were ~20s ;-)

@japhir
Copy link
Author

japhir commented Dec 9, 2020

I guess I had the naive view that "they're just a bunch of text files, there's no reason for this to be slow" without realising that the org files are quite complex to parse. I only got a real appreciation for this during the last Emacsconf :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants