-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* discoverConnections has no errors to return * error if parsing k8s object fails * Types for reporting file-processing errors * Functions to return multiple error objects * unit testing * not exporting parse functions * ScanK8sDeployObject -> ScanK8sWorkloadObject * Moving regexs to vars at the top of the file * Moving error type to controller package * discard FileProcessingErrorList * error should not start with a capital letter * create all error objects in error_types.go * DocumentID() returns an error + Location() method * Work with externally-provided logger * A missing not * implemented stop-on-first-error option * Fix lint issue * report line number when marshaling fails * PoliciesFromFolderPath() -> PoliciesSynthesizer * Logger.Errorf() takes error as an arg * A missing check to stop on first error * Always stop processing on fatal error * Not assuming a severe error is always last * separate logging from custom error interface * not relying on fatal error being the last error * Do not rely on fatal errors to be last Signed-off-by: Ziv Nevo <[email protected]>
- Loading branch information
Showing
21 changed files
with
1,543 additions
and
247 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,43 +1,24 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "os" | ||
| "syscall" | ||
|
|
||
| "go.uber.org/zap" | ||
|
|
||
| "github.com/np-guard/cluster-topology-analyzer/pkg/common" | ||
| "github.com/np-guard/cluster-topology-analyzer/pkg/controller" | ||
| ) | ||
|
|
||
| func runAnalysis() int { | ||
| logger := common.SetupLogger() | ||
| defer func() { | ||
| err := logger.Sync() | ||
| // If stderr is a TTY we might not be able to sync. | ||
| // See https://github.com/uber-go/zap/issues/991#issuecomment-962098428 for | ||
| // why we ignore ENOTTY. On OSX, we must ignore EBADF. | ||
| if err != nil && !errors.Is(err, syscall.ENOTTY) && !errors.Is(err, syscall.EBADF) { | ||
| panic(err) | ||
| } | ||
| }() | ||
|
|
||
| func main() { | ||
| var inArgs common.InArgs | ||
| err := common.ParseInArgs(&inArgs) | ||
| if err != nil { | ||
| zap.S().Debug("error parsing arguments, exiting...") | ||
| return 1 | ||
| fmt.Fprintf(os.Stderr, "error parsing arguments: %v. exiting...\n", err) | ||
| os.Exit(1) | ||
| } | ||
|
|
||
| err = controller.Start(inArgs) | ||
| if err != nil { | ||
| zap.S().Debug("error running topology analysis exiting...") | ||
| return 1 | ||
| fmt.Fprintf(os.Stderr, "error running topology analysis: %v. exiting...", err) | ||
| os.Exit(1) | ||
| } | ||
| return 0 | ||
| } | ||
|
|
||
| func main() { | ||
| os.Exit(runAnalysis()) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.