Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for the analyzer package #246

Merged
merged 5 commits into from
Jun 26, 2023
Merged

Testing for the analyzer package #246

merged 5 commits into from
Jun 26, 2023

Conversation

zivnevo
Copy link
Member

@zivnevo zivnevo commented Jun 22, 2023

As specified in #74

Also in the PR:

  • Not passing resource kind to scan functions, unless it is needed
  • parseResource now takes a byte-array and builds a bytes-reader, to avoid code duplication

Signed-off-by: Ziv Nevo <[email protected]>
Signed-off-by: Ziv Nevo <[email protected]>
Signed-off-by: Ziv Nevo <[email protected]>
Signed-off-by: Ziv Nevo <[email protected]>
Copy link

@shireenf-ibm shireenf-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@zivnevo zivnevo merged commit 4d5493a into main Jun 26, 2023
5 checks passed
@zivnevo zivnevo deleted the scan_test branch June 26, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants